1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
phorge-phorge/src/applications/repository
epriestley 35d03d36c7 Improve display behavior of commit messages in Diffusion
Summary:
See T372. Always render commit messages on one display line, so the table
doesn't jump around as they AJAX in on browse views.

The goal here is to have the cell choose a size naturally and for its content to
render with "overflow: hidden" if the natural size isn't large enough to contain
the content. "white-space: pre" or "white-space: nowrap" would prevent wrapping
but potentially make the table exceed the display width when a better behavior
is to hide some of the commit message.

Also use utf8-aware shortening, now that we have a function for it.

Casting a wide net in case anyone has a better way to do the CSS here. It's kind
of nasty that we have to use so many DOM nodes.

Test Plan:
  - Resized window while viewing browse and history views in Safari, Chrome and
Firefox. Table exhibited described behavior.
  - Verified summaries render sensibly and are properly truncated to 100
characters.

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen, tomo, mroch, cpojer
CC: aran, epriestley
Differential Revision: 750
2011-07-31 12:05:06 -07:00
..
constants/repositorytype Diffusion/phd/console improvements. 2011-03-15 13:38:14 -07:00
controller Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository' 2011-07-24 18:10:40 -07:00
daemon Allow SVN repositories to import subdirectories instead of the entire repository 2011-07-20 10:56:02 -07:00
parser Lint stragglers. 2011-04-03 23:38:02 -07:00
storage Improve display behavior of commit messages in Diffusion 2011-07-31 12:05:06 -07:00
worker Add commits to the Phabricator search index 2011-06-25 13:15:54 -07:00