1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/view
epriestley 35d03d36c7 Improve display behavior of commit messages in Diffusion
Summary:
See T372. Always render commit messages on one display line, so the table
doesn't jump around as they AJAX in on browse views.

The goal here is to have the cell choose a size naturally and for its content to
render with "overflow: hidden" if the natural size isn't large enough to contain
the content. "white-space: pre" or "white-space: nowrap" would prevent wrapping
but potentially make the table exceed the display width when a better behavior
is to hide some of the commit message.

Also use utf8-aware shortening, now that we have a function for it.

Casting a wide net in case anyone has a better way to do the CSS here. It's kind
of nasty that we have to use so many DOM nodes.

Test Plan:
  - Resized window while viewing browse and history views in Safari, Chrome and
Firefox. Table exhibited described behavior.
  - Verified summaries render sensibly and are properly truncated to 100
characters.

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen, tomo, mroch, cpojer
CC: aran, epriestley
Differential Revision: 750
2011-07-31 12:05:06 -07:00
..
base Get rid of +x on a bunch of nonexecutable files because I failed to set 2011-04-02 16:47:20 -07:00
control Improve display behavior of commit messages in Diffusion 2011-07-31 12:05:06 -07:00
dialog Allow projects to be quickly added from the Maniphest task creation interface 2011-06-13 10:17:08 -07:00
form Added a big warning if reviewer is about to accept a diff with lint or unit 2011-06-13 11:49:31 -07:00
layout Project list and profile view modifications 2011-06-20 16:13:44 -03:00
null Get rid of +x on a bunch of nonexecutable files because I failed to set 2011-04-02 16:47:20 -07:00
page Fix conservative CSRF token cycling limit 2011-07-14 08:09:40 -07:00
utils Use phabricator_ time functions in more places 2011-06-26 10:38:25 -07:00
widget/keyboardshortcuts Provide basic keyboard navigation support for Differential. 2011-06-09 14:55:44 -07:00