mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-13 09:06:14 +01:00
283a95d2aa
Summary: Adds a very basic list of all inline comments, threaded, and their status. Kept this a little simpler than the mock, mostly because sorting here feels a little strange given threads would be all over the place. Not sure sorted is needed in practice anyways. I'd probably lean towards just adding a JS checkbox to hide certain rows if needed in the future. Test Plan: Test various commenting structures: - Leave Comment - Update Diff - Leave new comment - Reply to comment - Reply to comment as revision author - Mark items as done - Update diff again {F4996915} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D18112
291 lines
6.4 KiB
PHP
291 lines
6.4 KiB
PHP
<?php
|
|
|
|
final class DifferentialInlineComment
|
|
extends Phobject
|
|
implements PhabricatorInlineCommentInterface {
|
|
|
|
private $proxy;
|
|
private $syntheticAuthor;
|
|
private $isGhost;
|
|
|
|
public function __construct() {
|
|
$this->proxy = new DifferentialTransactionComment();
|
|
}
|
|
|
|
public function __clone() {
|
|
$this->proxy = clone $this->proxy;
|
|
}
|
|
|
|
public function getTransactionCommentForSave() {
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorOldWorldContentSource::SOURCECONST);
|
|
|
|
$this->proxy
|
|
->setViewPolicy('public')
|
|
->setEditPolicy($this->getAuthorPHID())
|
|
->setContentSource($content_source)
|
|
->attachIsHidden(false)
|
|
->setCommentVersion(1);
|
|
|
|
return $this->proxy;
|
|
}
|
|
|
|
public function openTransaction() {
|
|
$this->proxy->openTransaction();
|
|
}
|
|
|
|
public function saveTransaction() {
|
|
$this->proxy->saveTransaction();
|
|
}
|
|
|
|
public function save() {
|
|
$this->getTransactionCommentForSave()->save();
|
|
|
|
return $this;
|
|
}
|
|
|
|
public function delete() {
|
|
$this->proxy->delete();
|
|
|
|
return $this;
|
|
}
|
|
|
|
public function supportsHiding() {
|
|
if ($this->getSyntheticAuthor()) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
public function isHidden() {
|
|
if (!$this->supportsHiding()) {
|
|
return false;
|
|
}
|
|
return $this->proxy->getIsHidden();
|
|
}
|
|
|
|
public function getID() {
|
|
return $this->proxy->getID();
|
|
}
|
|
|
|
public function getPHID() {
|
|
return $this->proxy->getPHID();
|
|
}
|
|
|
|
public static function newFromModernComment(
|
|
DifferentialTransactionComment $comment) {
|
|
|
|
$obj = new DifferentialInlineComment();
|
|
$obj->proxy = $comment;
|
|
|
|
return $obj;
|
|
}
|
|
|
|
public function setSyntheticAuthor($synthetic_author) {
|
|
$this->syntheticAuthor = $synthetic_author;
|
|
return $this;
|
|
}
|
|
|
|
public function getSyntheticAuthor() {
|
|
return $this->syntheticAuthor;
|
|
}
|
|
|
|
public function isCompatible(PhabricatorInlineCommentInterface $comment) {
|
|
return
|
|
($this->getAuthorPHID() === $comment->getAuthorPHID()) &&
|
|
($this->getSyntheticAuthor() === $comment->getSyntheticAuthor()) &&
|
|
($this->getContent() === $comment->getContent());
|
|
}
|
|
|
|
public function setContent($content) {
|
|
$this->proxy->setContent($content);
|
|
return $this;
|
|
}
|
|
|
|
public function getContent() {
|
|
return $this->proxy->getContent();
|
|
}
|
|
|
|
public function isDraft() {
|
|
return !$this->proxy->getTransactionPHID();
|
|
}
|
|
|
|
public function setChangesetID($id) {
|
|
$this->proxy->setChangesetID($id);
|
|
return $this;
|
|
}
|
|
|
|
public function getChangesetID() {
|
|
return $this->proxy->getChangesetID();
|
|
}
|
|
|
|
public function setIsNewFile($is_new) {
|
|
$this->proxy->setIsNewFile($is_new);
|
|
return $this;
|
|
}
|
|
|
|
public function getIsNewFile() {
|
|
return $this->proxy->getIsNewFile();
|
|
}
|
|
|
|
public function setLineNumber($number) {
|
|
$this->proxy->setLineNumber($number);
|
|
return $this;
|
|
}
|
|
|
|
public function getLineNumber() {
|
|
return $this->proxy->getLineNumber();
|
|
}
|
|
|
|
public function setLineLength($length) {
|
|
$this->proxy->setLineLength($length);
|
|
return $this;
|
|
}
|
|
|
|
public function getLineLength() {
|
|
return $this->proxy->getLineLength();
|
|
}
|
|
|
|
public function setCache($cache) {
|
|
return $this;
|
|
}
|
|
|
|
public function getCache() {
|
|
return null;
|
|
}
|
|
|
|
public function setAuthorPHID($phid) {
|
|
$this->proxy->setAuthorPHID($phid);
|
|
return $this;
|
|
}
|
|
|
|
public function getAuthorPHID() {
|
|
return $this->proxy->getAuthorPHID();
|
|
}
|
|
|
|
public function setRevision(DifferentialRevision $revision) {
|
|
$this->proxy->setRevisionPHID($revision->getPHID());
|
|
return $this;
|
|
}
|
|
|
|
public function getRevisionPHID() {
|
|
return $this->proxy->getRevisionPHID();
|
|
}
|
|
|
|
// Although these are purely transitional, they're also *extra* dumb.
|
|
|
|
public function setRevisionID($revision_id) {
|
|
$revision = id(new DifferentialRevision())->load($revision_id);
|
|
return $this->setRevision($revision);
|
|
}
|
|
|
|
public function getRevisionID() {
|
|
$phid = $this->proxy->getRevisionPHID();
|
|
if (!$phid) {
|
|
return null;
|
|
}
|
|
|
|
$revision = id(new DifferentialRevision())->loadOneWhere(
|
|
'phid = %s',
|
|
$phid);
|
|
if (!$revision) {
|
|
return null;
|
|
}
|
|
return $revision->getID();
|
|
}
|
|
|
|
// When setting a comment ID, we also generate a phantom transaction PHID for
|
|
// the future transaction.
|
|
|
|
public function setCommentID($id) {
|
|
$this->proxy->setTransactionPHID(
|
|
PhabricatorPHID::generateNewPHID(
|
|
PhabricatorApplicationTransactionTransactionPHIDType::TYPECONST,
|
|
DifferentialRevisionPHIDType::TYPECONST));
|
|
return $this;
|
|
}
|
|
|
|
public function setReplyToCommentPHID($phid) {
|
|
$this->proxy->setReplyToCommentPHID($phid);
|
|
return $this;
|
|
}
|
|
|
|
public function getReplyToCommentPHID() {
|
|
return $this->proxy->getReplyToCommentPHID();
|
|
}
|
|
|
|
public function setHasReplies($has_replies) {
|
|
$this->proxy->setHasReplies($has_replies);
|
|
return $this;
|
|
}
|
|
|
|
public function getHasReplies() {
|
|
return $this->proxy->getHasReplies();
|
|
}
|
|
|
|
public function setIsDeleted($is_deleted) {
|
|
$this->proxy->setIsDeleted($is_deleted);
|
|
return $this;
|
|
}
|
|
|
|
public function getIsDeleted() {
|
|
return $this->proxy->getIsDeleted();
|
|
}
|
|
|
|
public function setFixedState($state) {
|
|
$this->proxy->setFixedState($state);
|
|
return $this;
|
|
}
|
|
|
|
public function getFixedState() {
|
|
return $this->proxy->getFixedState();
|
|
}
|
|
|
|
public function setIsGhost($is_ghost) {
|
|
$this->isGhost = $is_ghost;
|
|
return $this;
|
|
}
|
|
|
|
public function getIsGhost() {
|
|
return $this->isGhost;
|
|
}
|
|
|
|
public function makeEphemeral() {
|
|
$this->proxy->makeEphemeral();
|
|
return $this;
|
|
}
|
|
|
|
public function getDateModified() {
|
|
return $this->proxy->getDateModified();
|
|
}
|
|
|
|
public function getDateCreated() {
|
|
return $this->proxy->getDateCreated();
|
|
}
|
|
|
|
/* -( PhabricatorMarkupInterface Implementation )-------------------------- */
|
|
|
|
|
|
public function getMarkupFieldKey($field) {
|
|
$content = $this->getMarkupText($field);
|
|
return PhabricatorMarkupEngine::digestRemarkupContent($this, $content);
|
|
}
|
|
|
|
public function newMarkupEngine($field) {
|
|
return PhabricatorMarkupEngine::newDifferentialMarkupEngine();
|
|
}
|
|
|
|
public function getMarkupText($field) {
|
|
return $this->getContent();
|
|
}
|
|
|
|
public function didMarkupText($field, $output, PhutilMarkupEngine $engine) {
|
|
return $output;
|
|
}
|
|
|
|
public function shouldUseMarkupCache($field) {
|
|
// Only cache submitted comments.
|
|
return ($this->getID() && !$this->isDraft());
|
|
}
|
|
|
|
}
|