mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
36e2d02d6e
Summary: `pht`ize a whole bunch of strings in rP. Test Plan: Intense eyeballing. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12797
115 lines
3.1 KiB
PHP
115 lines
3.1 KiB
PHP
<?php
|
|
|
|
final class DifferentialSetDiffPropertyConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.setdiffproperty';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Attach properties to Differential diffs.');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'diff_id' => 'required diff_id',
|
|
'name' => 'required string',
|
|
'data' => 'required string',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'void';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_NOT_FOUND' => pht('Diff was not found.'),
|
|
);
|
|
}
|
|
|
|
private static function updateLintStatus($diff_id) {
|
|
|
|
$diff = id(new DifferentialDiff())->load($diff_id);
|
|
if (!$diff) {
|
|
throw new ConduitException('ERR_NOT_FOUND');
|
|
}
|
|
|
|
// Load the postponed linters attached to this diff.
|
|
$postponed_linters_property = id(
|
|
new DifferentialDiffProperty())->loadOneWhere(
|
|
'diffID = %d AND name = %s',
|
|
$diff_id,
|
|
'arc:lint-postponed');
|
|
if ($postponed_linters_property) {
|
|
$postponed_linters = $postponed_linters_property->getData();
|
|
} else {
|
|
$postponed_linters = array();
|
|
}
|
|
|
|
// Load the lint messages currenty attached to the diff
|
|
$messages_property = id(new DifferentialDiffProperty())->loadOneWhere(
|
|
'diffID = %d AND name = %s',
|
|
$diff_id,
|
|
'arc:lint');
|
|
if ($messages_property) {
|
|
$results = $messages_property->getData();
|
|
} else {
|
|
$results = array();
|
|
}
|
|
|
|
$has_error = false;
|
|
$has_warning = false;
|
|
foreach ($results as $result) {
|
|
if ($result['severity'] === ArcanistLintSeverity::SEVERITY_ERROR) {
|
|
$has_error = true;
|
|
break;
|
|
} else if ($result['severity'] ===
|
|
ArcanistLintSeverity::SEVERITY_WARNING) {
|
|
$has_warning = true;
|
|
}
|
|
}
|
|
|
|
if ($has_error) {
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_FAIL);
|
|
} else if ($has_warning) {
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_WARN);
|
|
} else if (!empty($postponed_linters)) {
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_POSTPONED);
|
|
} else if ($diff->getLintStatus() != DifferentialLintStatus::LINT_SKIP) {
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_OKAY);
|
|
}
|
|
$diff->save();
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$diff_id = $request->getValue('diff_id');
|
|
$name = $request->getValue('name');
|
|
$data = json_decode($request->getValue('data'), true);
|
|
|
|
self::updateDiffProperty($diff_id, $name, $data);
|
|
|
|
if ($name === 'arc:lint' || $name == 'arc:lint-postponed') {
|
|
self::updateLintStatus($diff_id);
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
private static function updateDiffProperty($diff_id, $name, $data) {
|
|
$property = id(new DifferentialDiffProperty())->loadOneWhere(
|
|
'diffID = %d AND name = %s',
|
|
$diff_id,
|
|
$name);
|
|
if (!$property) {
|
|
$property = new DifferentialDiffProperty();
|
|
$property->setDiffID($diff_id);
|
|
$property->setName($name);
|
|
}
|
|
$property->setData($data);
|
|
$property->save();
|
|
return $property;
|
|
}
|
|
|
|
}
|