revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 378387a078 Fix an issue with mentioning revisions on the new EditEngine code 
Summary:
Ref T12020. Ref T11114. If we continue here on a mention, we try to generate `$old`, which requires reviewers to be attached. They won't be for simple codepaths like mentions.

Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.

Test Plan: Mentioned a revision on a task.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11114, T12020

Differential Revision: https://secure.phabricator.com/D17059
2016-12-14 14:11:10 -08:00
..
almanac Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit
audit Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
auth When rendering the "you were invited" header, query the inviting user with the omnipotent viewer 2016-12-09 08:35:34 -08:00
badges Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
base Rename all ProfilePanels into ProfileMenuItems 2016-12-11 11:44:38 -08:00
cache Introduce a serializing key-value cache proxy 2016-12-06 09:11:32 -08:00
calendar Set the viewer timezone properly on Calendar event RecurrenceSet objects 2016-12-02 07:29:48 -08:00
celerity Don't combine automatic output compression with "Content-Length" 2016-12-13 14:25:49 -08:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Use futures to improve clustered repository main page performance 2016-12-08 07:26:32 -08:00
config Remove a very old piece of config documentation 2016-12-12 23:22:21 +00:00
conpherence Use PhutilQueryCompiler in Phabricator fulltext search 2016-11-25 14:46:10 -08:00
console Remove "mysql.implementation" configuration 2016-11-22 04:15:34 -08:00
countdown Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
daemon Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
dashboard Allow Dashboards to set an icon 2016-12-13 11:30:22 -08:00
differential Fix an issue with mentioning revisions on the new EditEngine code 2016-12-14 14:11:10 -08:00
diffusion Use futures to improve clustered repository main page performance 2016-12-08 07:26:32 -08:00
diviner Remove unusual explicit calls to policy capability descriptions from Diviner 2016-12-14 11:23:05 -08:00
doorkeeper Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
draft/storage Clean up some log spam caused by races in VersionedDraft 2016-09-05 13:01:53 -07:00
drydock Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
fact
feed Prevent media from autoplaying when rendered as a feed story 2016-11-22 14:19:56 -08:00
files Prettier file embeds 2016-11-27 14:57:06 -08:00
flag
fund
guides Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
harbormaster Allow "Wait for Message" to be unset on build plans 2016-11-22 14:02:37 -08:00
help Use "book" instead of "life ring" icon for global help menu 2016-10-28 14:33:18 -07:00
herald In Remarkup, render archived Herald rules with strikethrough for consistency 2016-12-08 12:37:54 -08:00
home Revert "Clean up more Quicksand" 2016-10-01 12:58:30 -07:00
legalpad Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
lipsum
macro Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
maniphest Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks 2016-11-18 14:08:20 -08:00
meta Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
metamta Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
multimeter
notification Add an icon to aphlict connection status 2016-10-02 08:17:21 -07:00
nuance Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
oauthserver Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
owners Allow transactions to specialize their mail headers for diff sections 2016-11-07 12:16:39 -08:00
packages Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
passphrase Make Passphrase "token" credentials accessible via the API 2016-11-15 09:12:35 -08:00
paste Allow transactions to specialize their mail headers for diff sections 2016-11-07 12:16:39 -08:00
people Rename all ProfilePanels into ProfileMenuItems 2016-12-11 11:44:38 -08:00
phame Allow custom Sites to have custom 404 controllers 2016-11-30 15:25:09 -08:00
phid Use PhabricatorCachedClassMapQuery when querying object PHID types 2016-12-06 09:10:29 -08:00
phlux Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
pholio Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
phortune When a Phortune subscription has a removed payment method, be more explicit about it 2016-11-23 14:07:40 -08:00
phpast
phragment Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
phrequent Redesign Config Application 2016-08-29 15:49:49 -07:00
phriction Fix Phriction document move on to existing document placeholder 2016-10-18 11:58:24 +00:00
phurl Don't send Phurl mail to the URL object itself 2016-11-15 09:12:15 -08:00
policy Fix flaky subscribers policy rule unit test 2016-12-11 12:27:57 -08:00
ponder Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
project Rename all ProfilePanels into ProfileMenuItems 2016-12-11 11:44:38 -08:00
releeph Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
remarkup/conduit
repository Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
search Clean up Profile Menu Item page 2016-12-12 08:38:23 -08:00
settings Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
slowvote Prepare for event imports in Calendar 2016-10-12 10:45:31 -07:00
spaces Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
subscriptions
support/application
system Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
tokens Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
transactions Allow the new Differential EditEngine form to create/update diffs for revisions 2016-12-14 07:27:25 -08:00
typeahead Tokenize datasource indexes on "(" and ")" 2016-12-09 08:06:47 -08:00
uiexample Add setBackground to PHUIIconView 2016-08-19 13:19:53 -07:00
xhprof Removing deprecated method calls 2016-08-23 03:26:34 -05:00