1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 03:42:41 +01:00
phorge-phorge/src/applications/differential/field/specification
Nick Harper e4e56bb431 Return partial differential fields when there's an error parsing
Summary:
If someone typos one name in a cc or reviewer list, it would be nice if we
display all of the valid names in the field when running arc diff (in addition
to the error message).

Test Plan:
used the conduit console to check that calling differential.parsecommitmessage
with a list of some valid and some invalid ccs returns a result with both an
error and a list of some ccs. Also ran arc diff with that list of ccs to check
for the correct user experience.

Reviewers: epriestley, jungejason, vrana

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2542
2012-05-22 18:12:41 -07:00
..
applypatch Move Differential's simple fields to the extensible field schema 2011-08-15 08:39:48 -07:00
arcanistproject Move Differential's read-only fields to the extensible field schema 2011-08-15 08:39:58 -07:00
auditors Minor, ensure auditors is an array. 2012-03-06 19:46:26 -08:00
author Inform about disabled and away users in Differential fields 2012-05-16 18:39:33 -07:00
base Return partial differential fields when there's an error parsing 2012-05-22 18:12:41 -07:00
blamerev Validate all fields in differential.parsecommitmessage 2012-01-12 15:20:11 -08:00
branch Separate field for branch in revision 2012-02-06 17:28:46 -08:00
ccs Inform about disabled and away users in Differential fields 2012-05-16 18:39:33 -07:00
commits Move Differential's read-only fields to the extensible field schema 2011-08-15 08:39:58 -07:00
datecreated Drive differential revision list with custom fields 2012-02-20 05:38:21 -08:00
datemodified Drive differential revision list with custom fields 2012-02-20 05:38:21 -08:00
dependencies Move Differential's read-only fields to the extensible field schema 2011-08-15 08:39:58 -07:00
exportpatch Move Differential's simple fields to the extensible field schema 2011-08-15 08:39:48 -07:00
gitsvnid Drive Differential commit message parsing through extensible fields 2011-08-18 19:49:39 -07:00
host Move Differential's simple fields to the extensible field schema 2011-08-15 08:39:48 -07:00
lines Drive differential revision list with custom fields 2012-02-20 05:38:21 -08:00
lint Open files in very large diffs inline 2012-05-02 17:51:35 -07:00
maniphesttasks Return partial differential fields when there's an error parsing 2012-05-22 18:12:41 -07:00
path Separate field for branch in revision 2012-02-06 17:28:46 -08:00
revertplan Validate all fields in differential.parsecommitmessage 2012-01-12 15:20:11 -08:00
reviewedby Allow to resign from an accepted revision when you didn't accept the diff. 2011-10-19 15:27:36 -07:00
reviewers Move getPrimaryReviewer() to DifferentialRevision 2012-05-18 14:32:19 -07:00
revisionid Allow "Differential Revision ID" field appear on create/edit messages 2012-05-07 08:14:16 -07:00
revisionstatus Fix warnings for undefined $next_step and $verb 2012-05-10 11:43:35 -07:00
summary Fix an issue with empty 'Summary' fields in commit messages 2012-03-19 16:06:45 -07:00
testplan Support more aliases of "Test Plan" in commit messages 2012-05-22 06:02:12 -07:00
title Drive differential revision list with custom fields 2012-02-20 05:38:21 -08:00
unit Create option for differential custom fields to display warning on accept 2012-05-02 14:30:21 -07:00