mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-30 02:32:42 +01:00
870b01f2d0
Summary: Depends on D20416. Ref T13269. See D20329. If you try to save an "Assign to" rule with no assignee, we currently replace the control with an "InvalidRule" control that isn't editable. We'd prefer to give you an empty field back and let you pick a different value. Differentiate between "bad record format" (i.e., we can't really do anything with this) and "bad record value" (i.e., everything is structurally fine, you just typed the wrong thing). In the latter case, we still build a properly typed rule for the UI, we just refuse to update storage until you fix the problem. Test Plan: First, hit the original issue and got a nicer UI with a more consistent control width (note full-width error): {F6374205} Then, applied the rest of the patch and got a normal "fix the issue" form state instead of a dead-end: {F6374211} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13269 Differential Revision: https://secure.phabricator.com/D20417
39 lines
615 B
CSS
39 lines
615 B
CSS
/**
|
|
* @provides project-triggers-css
|
|
*/
|
|
|
|
.trigger-rules-table {
|
|
margin: 16px 0;
|
|
border-collapse: separate;
|
|
border-spacing: 0 4px;
|
|
}
|
|
|
|
.trigger-rules-table tr {
|
|
background: {$bluebackground};
|
|
}
|
|
|
|
.trigger-rules-table td {
|
|
padding: 6px 4px;
|
|
vertical-align: middle;
|
|
}
|
|
|
|
.trigger-rules-table td.type-cell {
|
|
padding-left: 6px;
|
|
}
|
|
|
|
.trigger-rules-table td.remove-column {
|
|
padding-right: 6px;
|
|
}
|
|
|
|
.trigger-rules-table td.invalid-cell {
|
|
padding-left: 12px;
|
|
width: 100%;
|
|
}
|
|
|
|
.trigger-rules-table td.invalid-cell .phui-icon-view {
|
|
margin-right: 4px;
|
|
}
|
|
|
|
.trigger-rules-table td.value-cell {
|
|
width: 100%;
|
|
}
|