mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-21 19:19:12 +01:00
b2b739c709
Summary: Ref T8726. I want to modularize values and reduce how hard-coded / copypasta'd they are. - Rename `get...StandardCondition()` to `get...StandardType()`, since we can drive both conditions and values from it. - Rename `STANDARD_LIST` to `STANDARD_PHID_LIST` for consistency: all "lists" are lists of PHIDs. - For all standard types which don't require typehaeads, lift their logic into the base class. - I'll lift typeaheads soon, but need to generalize them first. Test Plan: Edited various Herald rules, saw value UI generate correctly. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8726 Differential Revision: https://secure.phabricator.com/D13612
23 lines
663 B
PHP
23 lines
663 B
PHP
<?php
|
|
|
|
final class DifferentialRevisionSummaryHeraldField
|
|
extends DifferentialRevisionHeraldField {
|
|
|
|
const FIELDCONST = 'differential.revision.summary';
|
|
|
|
public function getHeraldFieldName() {
|
|
return pht('Revision summary');
|
|
}
|
|
|
|
public function getHeraldFieldValue($object) {
|
|
// NOTE: For historical reasons, this field includes the test plan. We
|
|
// could maybe try to fix this some day, but it probably aligns reasonably
|
|
// well with user expectation without harming anything.
|
|
return $object->getSummary()."\n\n".$object->getTestPlan();
|
|
}
|
|
|
|
protected function getHeraldFieldStandardType() {
|
|
return self::STANDARD_TEXT;
|
|
}
|
|
|
|
}
|