1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
phorge-phorge/src/docs
epriestley 99b9ceb6d7 Fix arcanist documentation to include "set -e" in example SVN hooks
Summary: "set -e" causes the script to exit if any command returns nonzero.
Without it, we incorrectly discard the failure code. At Facebook everything runs
in "set -e" or some equivalent so I never picked this up in testing.

Test Plan:
Added the hook to my svn local, it blocked bad commits and allowed good ones.

  >>> orbital:~/devtools/svnroot $ svn commit -m "quaa"
  Sending        test.php
  Transmitting file data .svn: Commit failed (details follow):
  svn: Commit blocked by pre-commit hook (exit code 1) with output:

  LINT ERRORS

  This changeset has lint errors. You must fix all lint errors before you can
  commit.

  You can add '@bypass-lint' to your commit message to disable lint checks for
  this commit, or '@nolint' to the file with errors to disable lint for that
  file.

  >>> Lint for test.php:

     Error  (XHP1) PHP Syntax Error!
      This file contains a syntax error: XHPAST Parse Error: syntax error,
      unexpected '}' on line 1

      >>>        1 <?php asdddddd;!}}

Reviewers: svemir, jungejason, tuomaspelkonen, aran

Reviewed By: svemir

CC: aran, svemir, epriestley

Differential Revision: 864
2011-08-26 11:51:38 -07:00
..
configuration Enable support for a single reply-handler for outbound emails 2011-08-22 10:20:49 +02:00
contributing Organize, update, and improve some documentation. 2011-06-25 20:33:25 -07:00
developer Update doc example. 2011-08-03 09:16:50 -07:00
flavortext Provide basic Celerity documentation. 2011-07-04 11:23:04 -07:00
technical Allow Phabricator storage engines to be extended and configured 2011-07-21 16:44:24 -07:00
userguide Fix arcanist documentation to include "set -e" in example SVN hooks 2011-08-26 11:51:38 -07:00
installation_guide.diviner Provide a basic update script for Phabricator 2011-06-29 20:05:28 -07:00
introduction.diviner Organize, update, and improve some documentation. 2011-06-25 20:33:25 -07:00
roadmap.diviner Update roadmap document. 2011-07-22 10:38:34 -07:00