1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/phrequent
epriestley 156b156e77 Give Conduit params/return/errors protected visibility
Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:
  - Ran `arc unit --everything`.
  - Called `conduit.query`.
  - Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380
2015-04-13 11:58:35 -07:00
..
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
controller Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
editor Conduit APIs to start and stop tracking time in phrequent 2014-07-12 11:42:32 +10:00
event Improve usability of Phrequent "Stop Time" dialog 2014-08-11 12:30:01 -07:00
interface Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
query Modernize more paging/order queries 2015-04-13 11:58:30 -07:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00