1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 13:38:19 +01:00
phorge-phorge/src/infrastructure/diff
epriestley 2188473fa7 Fix an issue where we may "min()" an empty array when viewing a revision with no changesets
Summary:
Ref T13667. When a revision's diff has no changesets (usually because Diffusion performed an automatic update with an empty commit), the UI currently tries to "min()" an empty array and fatals.

Handle this case properly.

Test Plan:
  - Created a revision with a diff with no changesets ("git commit --allow-empty" + copy-paste into web UI).
  - Viewed revision.
    - Before: "min()" fatal.
    - After: UI isn't perfect, but works without fataling.

Subscribers: cspeckmim

Maniphest Tasks: T13667

Differential Revision: https://secure.phabricator.com/D21760
2022-04-20 13:03:59 -07:00
..
__tests__ Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on 2019-02-19 10:55:10 -08:00
engine Fix an issue where we may "min()" an empty array when viewing a revision with no changesets 2022-04-20 13:03:59 -07:00
inline Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
interface Formally track "initial", "committed", and "active" states for inline comments 2021-03-29 09:00:27 -07:00
prose Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit 2020-07-23 07:46:15 -07:00
query Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
view Formally track "initial", "committed", and "active" states for inline comments 2021-03-29 09:00:27 -07:00
viewstate Fix an issue where non-ID changeset state keys were used as changeset IDs 2020-05-04 16:05:05 -07:00
PhabricatorChangesetResponse.php Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion 2020-04-19 08:59:09 -07:00
PhabricatorDifferenceEngine.php Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
PhabricatorDiffScopeEngine.php Make very minor generality improvements to the scope selector 2019-04-30 06:52:29 -07:00
PhabricatorInlineCommentController.php Update client logic for inline comment "Save" and "Cancel" actions 2021-03-29 09:00:27 -07:00