mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
3a87a95e11
Summary: Ref T603. Make almost every task read policy-aware. Notable exceptions are: - Edge editor -- this stuff is prescreened and should be moved to ApplicationTransactions eventually anyway. - Search/attach stuff -- this stuff needs some general work. The actual list should be fine since you can't pull handles. There may be a very indirect hole here where you could attach an object you can't see (but do know the ID of) to an object you can see. Pretty fluff. - The "Tasks" field in Differential will let you reference objects you can't see. Possibly this is desirable, in the case of commandeering revisions. Mostly, it was inconvenient to get a viewer (I think). Test Plan: - Called `maniphest.info`. - Called `maniphest.update`. - Batch edited tasks. - Dragged and dropped tasks to change subpriority. - Subscribed and unsubscribed from a task. - Edited a task. - Created a task. - Created a task with a parent. - Created a task with a template. - Previewed a task update. - Commented on a task. - Added a dependency. - Searched for "T33" in object search dialog. - Created a branch "T33", ran `arc diff`, verified link. - Pushed a commit with "Fixes T33", verified close. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7119
117 lines
3 KiB
PHP
117 lines
3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group search
|
|
*/
|
|
final class PhabricatorSearchSelectController
|
|
extends PhabricatorSearchBaseController {
|
|
|
|
private $type;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->type = $data['type'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$query = new PhabricatorSearchQuery();
|
|
$query_str = $request->getStr('query');
|
|
|
|
$query->setQuery($query_str);
|
|
$query->setParameter('type', $this->type);
|
|
|
|
switch ($request->getStr('filter')) {
|
|
case 'assigned':
|
|
$query->setParameter('owner', array($user->getPHID()));
|
|
$query->setParameter('open', 1);
|
|
break;
|
|
case 'created';
|
|
$query->setParameter('author', array($user->getPHID()));
|
|
// TODO - if / when we allow pholio mocks to be archived, etc
|
|
// update this
|
|
if ($this->type != PholioPHIDTypeMock::TYPECONST) {
|
|
$query->setParameter('open', 1);
|
|
}
|
|
break;
|
|
case 'open':
|
|
$query->setParameter('open', 1);
|
|
break;
|
|
}
|
|
|
|
$query->setParameter('exclude', $request->getStr('exclude'));
|
|
$query->setParameter('limit', 100);
|
|
|
|
$engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
|
|
$results = $engine->executeSearch($query);
|
|
|
|
$phids = array_fill_keys($results, true);
|
|
$phids += $this->queryObjectNames($query_str);
|
|
|
|
$phids = array_keys($phids);
|
|
$handles = $this->loadViewerHandles($phids);
|
|
|
|
$data = array();
|
|
foreach ($handles as $handle) {
|
|
$view = new PhabricatorHandleObjectSelectorDataView($handle);
|
|
$data[] = $view->renderData();
|
|
}
|
|
|
|
return id(new AphrontAjaxResponse())->setContent($data);
|
|
}
|
|
|
|
private function queryObjectNames($query) {
|
|
|
|
$pattern = null;
|
|
switch ($this->type) {
|
|
case ManiphestPHIDTypeTask::TYPECONST:
|
|
$pattern = '/\bT(\d+)\b/i';
|
|
break;
|
|
case DifferentialPHIDTypeRevision::TYPECONST:
|
|
$pattern = '/\bD(\d+)\b/i';
|
|
break;
|
|
case PholioPHIDTypeMock::TYPECONST:
|
|
$pattern = '/\bM(\d+)\b/i';
|
|
break;
|
|
}
|
|
|
|
if (!$pattern) {
|
|
return array();
|
|
}
|
|
|
|
$matches = array();
|
|
preg_match_all($pattern, $query, $matches);
|
|
if (!$matches) {
|
|
return array();
|
|
}
|
|
|
|
$object_ids = $matches[1];
|
|
if (!$object_ids) {
|
|
return array();
|
|
}
|
|
|
|
switch ($this->type) {
|
|
case DifferentialPHIDTypeRevision::TYPECONST:
|
|
$objects = id(new DifferentialRevision())->loadAllWhere(
|
|
'id IN (%Ld)',
|
|
$object_ids);
|
|
break;
|
|
case ManiphestPHIDTypeTask::TYPECONST:
|
|
// TODO: (T603) Clean this up. This should probably all run through
|
|
// ObjectQuery?
|
|
$objects = id(new ManiphestTask())->loadAllWhere(
|
|
'id IN (%Ld)',
|
|
$object_ids);
|
|
break;
|
|
case PholioPHIDTypeMock::TYPECONST:
|
|
$objects = id(new PholioMock())->loadAllWhere(
|
|
'id IN (%Ld)',
|
|
$object_ids);
|
|
break;
|
|
}
|
|
|
|
return array_fill_keys(mpull($objects, 'getPHID'), true);
|
|
}
|
|
|
|
}
|