1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications/people
epriestley 3ab6a7e19f Generate "stub" events earlier, so more infrastructure works with Calendar
Summary:
Ref T9275. When you create a recurring event which recurs forever, we want to avoid writing an infinite number of rows to the database.

Currently, we write a row to the database right before you edit the event. Until then, we refer to it as `E123/999` or whatever ("instance 999 of event 123").

This creates a big mess with trying to make recurring events work with EditEngine, Subscriptions, Projects, Flags, Tokens, etc -- all of this stuff assumes that whatever you're working with has a PHID.

I poked at letting this stuff work without a PHID a little bit, but that looked like a gigantic mess.

Instead, generate an event "stub" a little sooner (when you look at the event detail page). This is basically just an ID/PHID to refer to the instance.

Then, when you edit the stub, "materialize" it into a real event.

This still has some issues, but I think it's more promising than the other approach was.

Also:

  - Removes dead user profile calendar controller.
  - Replaces comments with EditEngine comments.

Test Plan:
  - Commented on a recurring event.
  - Awarded tokens to a recurring event.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9275

Differential Revision: https://secure.phabricator.com/D16248
2016-07-13 07:41:16 -07:00
..
application Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
cache Fix several issues with email-related global preferences 2016-06-14 12:35:31 -07:00
capability People - refine permissions on creating new users 2015-02-05 16:47:09 -08:00
conduit Add a modern user.search Conduit API method 2016-05-22 05:54:31 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
customfield Fix object extraction from user profile blurbs 2016-02-01 09:46:45 -08:00
editor Use new modular temporary auth token constants in one-time login and password reset flows 2016-03-16 09:33:24 -07:00
engine Remove calendar panel in profile and make calendar box header a link to user's calendar 2016-05-23 11:32:56 -07:00
engineextension New People Hovercards 2016-02-11 15:41:55 -08:00
extension Convert user profile images into a standard cache 2016-06-05 08:52:15 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
icon Add additional icons for User Profiles 2016-01-31 20:09:06 +00:00
lipsum Improve bin/lipsum UX 2015-12-24 09:06:35 -08:00
markup Improve some Phame custom domain remarkup and link behaviors 2016-06-02 06:28:06 -07:00
phid Always give users "fa-user" icons in tokenizers 2016-02-01 09:49:12 -08:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
profilepanel Fix spelling error 2016-04-11 09:26:08 -07:00
query Simplify user cache management of data forms 2016-06-05 08:53:27 -07:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
searchfield Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
storage Don't show client-side setup prompts until user accounts activate 2016-06-22 11:54:15 -07:00
typeahead Render browse results with global result style 2016-06-20 16:49:02 -07:00
view New People Hovercards 2016-02-11 15:41:55 -08:00