mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 17:32:41 +01:00
a161617d8e
Summary: does the title and also a few other small tweaks - kills the init js behavior; now its part of menu where it belongs. - adds the underline to the icon when its toggled in the widget menu - fixed JS initialization errors on the "create conpherence" page. Note I still like keeping all that init stuff in one function because its typing the same data a bunch to be passed over to the JS layer. Other ways to accomplish this obvi... Only fun wrinkle here is I think Chad intended me to display "when the file was attached". Instead, I display when the file was *uploaded*. I think this jives better with our version where you can't delete and all that. Files are pretty powerful, long-living objects in Phabricator land. Test Plan: added files to a conpherence and noted widget loaded updated okay. added a file with no author (generated by the system) and verified it still rendered okay. switched between conpherences and verified proper data in each files widget. uploaded image and text files to check the icons were correct. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5337 |
||
|---|---|---|
| .. | ||
| ConpherenceFileWidgetView.php | ||
| ConpherenceFormDragAndDropUploadControl.php | ||
| ConpherenceMenuItemView.php | ||
| ConpherencePontificateControl.php | ||
| ConpherenceTransactionView.php | ||