1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
phorge-phorge/src/infrastructure/diff
epriestley 3be36783b3 Consider inline comments with draft checkmarks as "unsubmitted"
Summary:
Ref T12733. When a revision has unsubmitted checkmarks:

  - Color the banner yellow.
  - Show them in the "X unsubmitted" count.
  - Make the "X unsubmitted" button cycle between all drafts (written but unpublished comments) and "draft done" (checked but unsubmitted "Done" checkbox comments).

Test Plan:
  - Checked a "Done" box, saw "1 unsubmitted" and yellow banner.
  - Clicked "5 unsubmitted" repeatedly, saw it cycle through all unsubmitted comments and checkboxes.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D18127
2017-06-15 05:22:58 -07:00
..
interface Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
query Publish draft "done" status when submitting comments/updates/actions/inlines 2015-03-24 05:26:12 -07:00
view Consider inline comments with draft checkmarks as "unsubmitted" 2017-06-15 05:22:58 -07:00
PhabricatorChangesetResponse.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
PhabricatorDifferenceEngine.php Extend from Phobject 2015-06-15 18:02:27 +10:00
PhabricatorInlineCommentController.php Move inline replies to new code and remove DifferentialInlineEditor 2017-05-16 06:23:51 -07:00
PhabricatorInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00