1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/phid
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
application Implement very basic uberhome 2013-01-15 15:41:22 -08:00
conduit Require a viewer to load handles 2013-02-28 17:15:09 -08:00
config Formalize phid.external-loaders 2013-01-19 10:20:24 -08:00
controller Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
handle Require a viewer to load handles 2013-02-28 17:15:09 -08:00
storage Genericize transactions in Pholio 2012-12-11 13:59:20 -08:00
PhabricatorObjectHandle.php Render commit summaries when rendering handles 2013-02-21 15:09:35 -08:00
PhabricatorPHIDConstants.php Conpherence V1 2013-01-24 17:23:05 -08:00
utils.php Add feed integration to generic transactions 2012-12-11 14:00:21 -08:00