1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
phorge-phorge/webroot/rsrc/js/phuix
epriestley adb1d3a5be Fix autocomplete/send-on-enter interactions
Summary:
Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type `someone is 100% to blame here (@epriestley)` and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan:
  - Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  - Typed ":", ")", "<return>", sent an emoticon (previously: no).

Reviewers: chad, amckinley

Reviewed By: chad

Subscribers: xxx

Differential Revision: https://secure.phabricator.com/D17794
2017-04-26 08:48:25 -07:00
..
PHUIXActionListView.js Begin rebuilding dropdown menus on ActionList 2014-05-05 10:56:14 -07:00
PHUIXActionView.js Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
PHUIXAutocomplete.js Fix autocomplete/send-on-enter interactions 2017-04-26 08:48:25 -07:00
PHUIXDropdownMenu.js Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
PHUIXFormControl.js When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
PHUIXIconView.js Basic stacked action support for EditEngine 2015-12-03 12:32:02 -08:00