mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-21 03:08:40 +01:00
106e90dcf0
Summary: Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of `willApplyTransactions()`. It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content. This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.) Test Plan: - Created and edited a paste. - Grepped for `willApplyTransactions()`. Note that `EditEngine` (vs `ApplicationTransacitonEditor`) still has a `willApplyTransactions()`, which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13222 Differential Revision: https://secure.phabricator.com/D19909
116 lines
2.7 KiB
PHP
116 lines
2.7 KiB
PHP
<?php
|
|
|
|
final class PhabricatorPasteContentTransaction
|
|
extends PhabricatorPasteTransactionType {
|
|
|
|
const TRANSACTIONTYPE = 'paste.create';
|
|
|
|
public function generateOldValue($object) {
|
|
return $object->getFilePHID();
|
|
}
|
|
|
|
public function applyInternalEffects($object, $value) {
|
|
$object->setFilePHID($value);
|
|
}
|
|
|
|
public function extractFilePHIDs($object, $value) {
|
|
return array($value);
|
|
}
|
|
|
|
public function validateTransactions($object, array $xactions) {
|
|
if ($object->getFilePHID() || $xactions) {
|
|
return array();
|
|
}
|
|
|
|
$error = $this->newError(
|
|
pht('Required'),
|
|
pht('You must provide content to create a paste.'));
|
|
$error->setIsMissingFieldError(true);
|
|
|
|
return array($error);
|
|
}
|
|
|
|
public function generateNewValue($object, $value) {
|
|
// If this transaction does not really change the paste content, return
|
|
// the current file PHID so this transaction no-ops.
|
|
$old_content = $object->getRawContent();
|
|
if ($value === $old_content) {
|
|
$file_phid = $object->getFilePHID();
|
|
if ($file_phid) {
|
|
return $file_phid;
|
|
}
|
|
}
|
|
|
|
$editor = $this->getEditor();
|
|
$actor = $editor->getActor();
|
|
|
|
$file = $this->newFileForPaste($actor, $value);
|
|
|
|
return $file->getPHID();
|
|
}
|
|
|
|
private function newFileForPaste(PhabricatorUser $actor, $data) {
|
|
return PhabricatorFile::newFromFileData(
|
|
$data,
|
|
array(
|
|
'name' => 'raw.txt',
|
|
'mime-type' => 'text/plain; charset=utf-8',
|
|
'authorPHID' => $actor->getPHID(),
|
|
'viewPolicy' => PhabricatorPolicies::POLICY_NOONE,
|
|
));
|
|
}
|
|
|
|
public function getIcon() {
|
|
return 'fa-plus';
|
|
}
|
|
|
|
public function getTitle() {
|
|
return pht(
|
|
'%s edited the content of this paste.',
|
|
$this->renderAuthor());
|
|
}
|
|
|
|
public function getTitleForFeed() {
|
|
return pht(
|
|
'%s edited %s.',
|
|
$this->renderAuthor(),
|
|
$this->renderObject());
|
|
}
|
|
|
|
public function hasChangeDetailView() {
|
|
return true;
|
|
}
|
|
|
|
public function getMailDiffSectionHeader() {
|
|
return pht('CHANGES TO PASTE CONTENT');
|
|
}
|
|
|
|
public function newChangeDetailView() {
|
|
$viewer = $this->getViewer();
|
|
|
|
$old = $this->getOldValue();
|
|
$new = $this->getNewValue();
|
|
|
|
$files = id(new PhabricatorFileQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($old, $new))
|
|
->execute();
|
|
$files = mpull($files, null, 'getPHID');
|
|
|
|
$old_text = '';
|
|
if (idx($files, $old)) {
|
|
$old_text = $files[$old]->loadFileData();
|
|
}
|
|
|
|
$new_text = '';
|
|
if (idx($files, $new)) {
|
|
$new_text = $files[$new]->loadFileData();
|
|
}
|
|
|
|
return id(new PhabricatorApplicationTransactionTextDiffDetailView())
|
|
->setViewer($viewer)
|
|
->setOldText($old_text)
|
|
->setNewText($new_text);
|
|
}
|
|
|
|
}
|