epriestley 75c3598359 Require commit identities when editing commits to resolve an issue with audit actions not applying properly ... Summary: See <https://discourse.phabricator-community.org/t/cannot-audit-a-git-commit/2848>. In D20581, I made some audit behavior dependent upon identities, but the actual edit flow doesn't load them. This can cause us to raise an "attach identities first" exception in the bowels of the edit workflow and trigger unexpected behavior at top level. Load identities when editing a commit so that the transaction flows have access to identity information and can use it to figure out if a user is an author, etc. Test Plan: - As an auditor, applied an "Accept Commit" action to an open audit after D20581. - Before patch: accept no-ops internally since the preconditions throw. - After patch: accept works properly. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20612		2019-06-24 10:50:23 -07:00
..
DiffusionCommitEditEngine.php	Require commit identities when editing commits to resolve an issue with audit actions not applying properly	2019-06-24 10:50:23 -07:00
DiffusionRepositoryEditEngine.php	Deprecate "Track Only" in the Diffusion UI	2019-04-18 05:40:02 -07:00
DiffusionRepositoryIdentityEditor.php	Add controllers/search/edit engine functionality to RepositoryIdentity	2018-05-31 07:03:25 -07:00
DiffusionURIEditEngine.php	Allow "Change Subtype" to be selected from the comment action stack	2018-11-28 13:40:40 -08:00
DiffusionURIEditor.php	Fix several safety issues with repository URIs	2017-11-30 14:06:21 -08:00