1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/infrastructure/storage
epriestley 3c5668b4a5 When database connection exceptions occur, raise them to the setup layer
Summary:
Ref T13141. Currently, during first-time setup we don't surface all the details about connection exceptions that we could: the underlying exception is discarded inside cluster connection management.

This isn't a huge issue since the reason for connection problems is usually fairly obvious, but in at least one case (see T13141) we hit a less-than-obvious exception.

Instead, store the original exception and propagate the message up the stack so users have more information about the problem.

Test Plan:
  - Configured an intentionally bad MySQL username.
  - Restarted Apache and loaded Phabricator.
  - Got a more helpful exception with a specific authentication error message.

{F5622361}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13141

Differential Revision: https://secure.phabricator.com/D19454
2018-05-18 09:02:36 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
lisk When database connection exceptions occur, raise them to the setup layer 2018-05-18 09:02:36 -07:00
management Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
patch Add initial infrastructure for adding ModularTransaction support to Application config changes 2017-04-19 15:44:57 -07:00
schema When storage is partitioned, refuse to serve requests unless web and databases agree on partitioning 2016-11-22 04:15:46 -08:00