mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 01:32:42 +01:00
dc7e40ff3f
Summary: See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors. The new Content-Security-Policy prevents this from functioning. Replace this with a more modern behavior-driven action instead. Test Plan: - Clicked some errors in DarkConsole, saw stack traces appear. - Grepped for `onclick` and `jsprintf()` to see if I could find any more of these, but came up empty. Maniphest Tasks: T13102 Differential Revision: https://secure.phabricator.com/D19218
102 lines
2.4 KiB
PHP
102 lines
2.4 KiB
PHP
<?php
|
|
|
|
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
|
|
|
|
public function getName() {
|
|
$count = count($this->getData());
|
|
if ($count) {
|
|
return pht('Error Log (%d)', $count);
|
|
}
|
|
return pht('Error Log');
|
|
}
|
|
|
|
public function getOrder() {
|
|
return 0;
|
|
}
|
|
|
|
public function getColor() {
|
|
if (count($this->getData())) {
|
|
return '#ff0000';
|
|
}
|
|
return null;
|
|
}
|
|
|
|
public function getDescription() {
|
|
return pht('Shows errors and warnings.');
|
|
}
|
|
|
|
public function generateData() {
|
|
return DarkConsoleErrorLogPluginAPI::getErrors();
|
|
}
|
|
|
|
public function renderPanel() {
|
|
$data = $this->getData();
|
|
|
|
$rows = array();
|
|
$details = array();
|
|
|
|
foreach ($data as $index => $row) {
|
|
$file = $row['file'];
|
|
$line = $row['line'];
|
|
|
|
$tag = javelin_tag(
|
|
'a',
|
|
array(
|
|
'sigil' => 'darkconsole-expand',
|
|
'meta' => array(
|
|
'expandID' => 'row-details-'.$index,
|
|
),
|
|
),
|
|
$row['str'].' at ['.basename($file).':'.$line.']');
|
|
$rows[] = array($tag);
|
|
|
|
$details[] = hsprintf(
|
|
'<div class="dark-console-panel-error-details" id="row-details-%s">'.
|
|
"%s\nStack trace:\n",
|
|
$index,
|
|
$row['details']);
|
|
|
|
foreach ($row['trace'] as $key => $entry) {
|
|
$line = '';
|
|
if (isset($entry['class'])) {
|
|
$line .= $entry['class'].'::';
|
|
}
|
|
$line .= idx($entry, 'function', '');
|
|
$href = null;
|
|
if (isset($entry['file'])) {
|
|
$line .= ' called at ['.$entry['file'].':'.$entry['line'].']';
|
|
try {
|
|
$user = $this->getRequest()->getUser();
|
|
$href = $user->loadEditorLink($entry['file'], $entry['line'], null);
|
|
} catch (Exception $ex) {
|
|
// The database can be inaccessible.
|
|
}
|
|
}
|
|
|
|
$details[] = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
),
|
|
$line);
|
|
$details[] = "\n";
|
|
}
|
|
|
|
$details[] = hsprintf('</div>');
|
|
}
|
|
|
|
$table = new AphrontTableView($rows);
|
|
$table->setClassName('error-log');
|
|
$table->setHeaders(array(pht('Error')));
|
|
$table->setNoDataString(pht('No errors.'));
|
|
|
|
return phutil_tag(
|
|
'div',
|
|
array(),
|
|
array(
|
|
phutil_tag('div', array(), $table->render()),
|
|
phutil_tag('pre', array('class' => 'PhabricatorMonospaced'), $details),
|
|
));
|
|
}
|
|
|
|
}
|