1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential/view
epriestley 3c8bb8a608 Fix comment anchor jump highlighting
Summary: I accidentally broke the feature where we highlight comments which are
jumped to via anchor in D1327. We now test that the jump was sucessful by
looking for an item with the anchor ID, but we were only setting 'name'.
Instead, set 'id' as well so the highlighting code detects that the jump was
successful and adds the highlight class.

Test Plan: Clicked "Comment D1234#7" or whatever, got a nice yellow background.

Reviewers: btrahan, nh, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T796

Differential Revision: https://secure.phabricator.com/D1471
2012-01-24 09:44:20 -08:00
..
addcomment Improve behavior when user submits a no-op action in Differential 2012-01-15 03:44:09 -08:00
changesetdetailview Add "Reveal Entire File" option to Diffusion 2012-01-06 11:51:10 -08:00
changesetlistview Declare property 2012-01-16 17:36:11 -08:00
difftableofcontents Display link in Revision ToC for copied or moved files 2012-01-16 09:10:17 -08:00
inlinecomment Retry failed page anchor navigation 2012-01-05 18:02:02 -08:00
localcommits Display local commit information in Differential 2011-08-31 13:49:50 -07:00
primarypane Allow comment panel to be stuck/unstuck to the bottom of the display 2011-07-08 13:24:20 -07:00
revisioncomment Fix comment anchor jump highlighting 2012-01-24 09:44:20 -08:00
revisioncommentlist Link to undisplayed inline comments 2012-01-06 11:50:59 -08:00
revisiondetail Hide auxiliary fields that have no value set 2011-12-16 16:49:45 -08:00
revisionlist Unify terminology in Differential overview 2012-01-23 17:39:49 -08:00
revisionupdatehistory Display base correctly for git-svn in update history 2012-01-08 12:18:22 -08:00