1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/config/schema
epriestley d67b7f0f47 Correct column mutations for old versions of MySQL
Summary:
Ref T1191. Although I fixed some of the mutations earlier (in D10598), I missed the column mutations under old versions of MySQL. In particular, this isn't valid:

  - `ALTER TABLE ... MODIFY columnName VARCHAR(64) COLLATE binary`

Issue the permitted version of this instead, which is:

  - `ALTER TABLE ... MODIFY columnName VARBINARY(64)`

Also fixed an issue where a clean schema had the wrong nullability for a column in the draft table. Force it to the expected nullability.

The other trick here is around the one column with a FULLTEXT index on it, which needs a little massaging.

Test Plan:
  - Forced my local install to return `false` for utf8mb4 support.
  - Did a clean adjust into `binary` columns.
  - Poked around, added emoji to things.
  - Reverted the fake check and did a clean adjust into `utf8mb4` columns.
  - Emoji survived.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: fabe, epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10627
2014-10-02 14:44:22 -07:00
..
PhabricatorConfigColumnSchema.php Support AUTO_INCREMENT in bin/storage adjust 2014-10-01 08:24:51 -07:00
PhabricatorConfigCoreSchemaSpec.php Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
PhabricatorConfigDatabaseSchema.php Generate expected and comparison schemata 2014-09-18 08:22:54 -07:00
PhabricatorConfigKeySchema.php Fix almost all remaining schemata issues 2014-10-01 08:18:36 -07:00
PhabricatorConfigSchemaQuery.php Support AUTO_INCREMENT in bin/storage adjust 2014-10-01 08:24:51 -07:00
PhabricatorConfigSchemaSpec.php Correct column mutations for old versions of MySQL 2014-10-02 14:44:22 -07:00
PhabricatorConfigServerSchema.php Generate expected and comparison schemata 2014-09-18 08:22:54 -07:00
PhabricatorConfigStorageSchema.php Support AUTO_INCREMENT in bin/storage adjust 2014-10-01 08:24:51 -07:00
PhabricatorConfigTableSchema.php Fix almost all remaining schemata issues 2014-10-01 08:18:36 -07:00