1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/infrastructure/markup
epriestley 3d3fff4991 Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues
Summary:
Fixes T10381. When we converted to `PHUIRemarkupView`, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).

Fix this so we don't preserve linebreaks.

This also makes `PHUIRemarkupView` a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of `PhabricatorMarkupInterface` / `PhabricatorMarkupOneOff`, and dropping all the application hard-coding in `PhabricatorMarkupEngine`.

Test Plan:
  - Grepped for all callsites, looking for callsites which accept remarkup written in `<<<HEREDOC` format.
  - Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10381

Differential Revision: https://secure.phabricator.com/D15963
2016-05-22 12:23:05 -07:00
..
interpreter Put cows and figlet bannners in <pre> in HTML mail bodies 2015-10-08 20:03:15 -07:00
rule Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
view Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
PhabricatorMarkupEngine.php Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
PhabricatorMarkupInterface.php Remove @group annotations 2014-07-10 08:12:48 +10:00
PhabricatorMarkupOneOff.php Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
PhabricatorMarkupPreviewController.php Disable caching of remarkup previews 2015-02-22 05:39:25 -08:00
PhabricatorSyntaxHighlighter.php Extend from Phobject 2015-06-15 18:02:27 +10:00