1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/differential/render
epriestley e9f4a84a89 Allow inline comments to be individually hidden
Summary:
Ref T7447. Implements per-viewer comment hiding. Once a comment is obsolete or uninteresting, you can hide it completely.

This is sticky per-user.

My hope is that this will strike a better balance between concerns than some of the other approaches (conservative porting, summarization, hide-all).

Specifically, this adds a new action here:

{F435621}

Clicking it completely collapses the comment into a small icon on the previous line, and saves the comment state as hidden for you:

{F435626}

You can click the icon to reveal all hidden comments below the line.

Test Plan:
  - Hid comments.
  - Showed comments.
  - Created, edited, deleted and submitted comments.
  - Used Diffusion comments (hiding is not implemented there yet, but I'd plan to bring it there eventually if it works out in Differential).

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: jparise, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D13009
2015-05-27 10:28:38 -07:00
..
DifferentialChangesetHTMLRenderer.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialChangesetOneUpRenderer.php Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
DifferentialChangesetOneUpTestRenderer.php Make "Show Context" persist rendering, whitespace, encoding, etc 2015-03-05 14:03:00 -08:00
DifferentialChangesetRenderer.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialChangesetTestRenderer.php Don't highlight very large files by default 2015-03-24 05:26:39 -07:00
DifferentialChangesetTwoUpRenderer.php Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
DifferentialChangesetTwoUpTestRenderer.php Make "Show Context" persist rendering, whitespace, encoding, etc 2015-03-05 14:03:00 -08:00
DifferentialRawDiffRenderer.php Move more hunk loads into DifferentialHunkQuery 2014-06-03 18:01:19 -07:00