mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 01:12:41 +01:00
d6247ffca5
Summary: Ref T7703. See that task and inline for a bunch of discussion. Briefly, when we run implicit policy rules ("to see a revision, you must also be able to see its repository") at query time, they don't apply to other viewers we might check later. We do this very rarely, but when we do we're often doing it for a bunch of different viewers (for example, in Herald) so I don't want to just reload the object a million times. Test Plan: - Added and executed unit tests. - Wrote a "flag everything" Herald rule, as in the original report in T7703, and no longer got "Unknown Object" flags on revisions. - Rigged up a lot of cases in the web UI and couldn't find any inconsistencies, although this case is normally very hard to hit. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7703 Differential Revision: https://secure.phabricator.com/D13104 |
||
|---|---|---|
| .. | ||
| PhabricatorPolicyAwareTestQuery.php | ||
| PhabricatorPolicyDataTestCase.php | ||
| PhabricatorPolicyTestCase.php | ||
| PhabricatorPolicyTestObject.php | ||