1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 21:48:21 +01:00
phorge-phorge/src/applications/harbormaster
epriestley cc8cbed029 Make "DifferentialDiff->properties" a proper "attachable" property
Summary:
See PHI498. This should be initialized to "self::ATTACHABLE" like other attachable properties, but is currently initialized to "array()".

Initialize it the normal way and try to catch all code paths which may have accessed it without actually loading and attaching it.

Also, remove UI for the very old "excuse" property, which "arc" has not written for well more than a year.

Test Plan: Grepped for affected symbols, loaded various revision pages. Somewhat tricky to be 100% sure that every pathway is caught, but it should be obvious if I missed anything once someone hits the code path.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D21710
2021-07-27 13:39:12 -07:00
..
__tests__ As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers 2018-02-26 17:56:52 -08:00
application Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
artifact Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
autoplan Give "Arcanist Client Results" a more clear name 2015-09-09 19:18:08 -07:00
capability Add spelling TODOs 2017-10-09 11:56:53 -07:00
codex Make the new Build Plan "Runnable" behavior work 2019-03-06 06:01:02 -08:00
conduit Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables 2021-07-21 14:17:00 -07:00
constants Modularize almost all Harbormaster build message workflows and UI/UX 2021-07-21 14:16:56 -07:00
controller Rename "HarbormasterRestartException" to "HarbormasterMessageException" 2021-07-21 14:17:00 -07:00
customfield Allow "Wait for Message" to be unset on build plans 2016-11-22 14:02:37 -08:00
editor Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods 2021-07-21 14:16:59 -07:00
engine Modularize individual Harbormaster build messages 2021-07-21 14:16:56 -07:00
engineextension Subsume 'harbormaster.querybuilds' with a modern search API method 2016-07-31 21:44:22 +00:00
event Reduce the severity of policy fatals when building the Harbormaster "build status" element 2018-03-16 13:27:57 -07:00
exception Rename "HarbormasterRestartException" to "HarbormasterMessageException" 2021-07-21 14:17:00 -07:00
future Update some Phabricator behaviors for changes to Futures 2020-04-03 12:28:16 -07:00
herald Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
interface When publishing buildables in Differential, ignore autobuilds (local lint and unit) 2018-04-03 11:02:12 -07:00
management Rename "HarbormasterRestartException" to "HarbormasterMessageException" 2021-07-21 14:17:00 -07:00
phid Add a very basic standalone view for build logs with a "Download Log" button 2018-02-26 17:53:10 -08:00
plan Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans 2019-03-25 11:24:04 -07:00
query Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage" 2021-07-21 14:16:53 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Remove "HarbormasterBuildCommand" 2021-07-21 14:16:57 -07:00
stepgroup Add an "Abort Older Builds" build step to Harbormaster 2018-04-17 14:59:47 -07:00
storage Modularize "HarbormasterBuildableTransaction" 2021-07-21 14:16:58 -07:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
view Make "DifferentialDiff->properties" a proper "attachable" property 2021-07-27 13:39:12 -07:00
worker Stop build target start times from being overwritten on reentry 2018-04-27 12:25:45 -07:00
xaction Rename "HarbormasterRestartException" to "HarbormasterMessageException" 2021-07-21 14:17:00 -07:00