mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-11 08:06:13 +01:00
0b1d6a3f6e
Summary: Ref T2543. These are the last `ArcanistDifferentialRevisionStatus` callsites. This removes the very old legacy `precommitRevisionStatus` field, which has no other readers. This was obsoleted by the `CLOSED_FROM_ACCEPTED` stuff, but retained for compatibility. Test Plan: - Poked these with the test console, although they're a little tricky to be sure about. - Grepped for `ArcanistDifferentialRevisionStatus`, no more hits. Reviewers: chad Reviewed By: chad Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18416
40 lines
934 B
PHP
40 lines
934 B
PHP
<?php
|
|
|
|
final class DiffusionPreCommitContentRevisionAcceptedHeraldField
|
|
extends DiffusionPreCommitContentHeraldField {
|
|
|
|
const FIELDCONST = 'diffusion.pre.content.revision.accepted';
|
|
|
|
public function getHeraldFieldName() {
|
|
return pht('Accepted Differential revision');
|
|
}
|
|
|
|
public function getFieldGroupKey() {
|
|
return HeraldRelatedFieldGroup::FIELDGROUPKEY;
|
|
}
|
|
|
|
public function getHeraldFieldValue($object) {
|
|
$revision = $this->getAdapter()->getRevision();
|
|
if (!$revision) {
|
|
return null;
|
|
}
|
|
|
|
if ($revision->isAccepted()) {
|
|
return $revision->getPHID();
|
|
}
|
|
|
|
$was_accepted = DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED;
|
|
if ($revision->isPublished()) {
|
|
if ($revision->getProperty($was_accepted)) {
|
|
return $revision->getPHID();
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
protected function getHeraldFieldStandardType() {
|
|
return self::STANDARD_PHID_BOOL;
|
|
}
|
|
|
|
}
|