revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 05:11:05 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/herald
History
epriestley 4fa99374be Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 
Summary:
See <https://discourse.phabricator-community.org/t/herald-webhook-is-not-called-but-herald-transcript-tells-me-the-opposite/1098>.

The "Commit Hook" events don't operate on objects and don't use TransactionEditors. They can't call webhooks in a normal way and currently don't call webhooks at all. Stop offering these actions in the UI.

The  "Outbound Mail" event also fires oddly and likely doesn't make much sense to hook anyway.

Test Plan: Verified that these events no longer offer "Call webhooks", while normal events still do.

Differential Revision: https://secure.phabricator.com/D19061
2018-02-11 06:15:29 -08:00
..
action Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
adapter Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
application Document how webhooks work 2018-02-09 13:57:19 -08:00
capability Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
config Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
editor Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
engine Implement an "only if the rule did not match last time" policy for Herald rules 2018-01-26 11:06:13 -08:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Add an "Acting user" field to Herald 2018-02-08 09:52:18 -08:00
garbagecollector Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
management Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
phid Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
query Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
typeahead Add a "Call webhooks" action to Herald 2018-02-09 13:56:57 -08:00
value Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00
view Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
worker Document how webhooks work 2018-02-09 13:57:19 -08:00
xaction Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00