1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
No description
Find a file
grglr 3f3304fd61 Differential whitespace mode IGNORE ALL now shows correct indentation
Summary:
Fixed buggy and incomplete logic for handling IGNORE ALL mode properly.
A subparser is used to parse the non-ws-ignoring changeset while a
ws-ignoring changeset is handed off to the original parser.  At a later
step, the original parser queries the subparser for its lines of text
(which are formatted properly due to being in non-ws-ignoring mode) and
uses them to replace the text in the ws-ignoring diff.

Task ID: 549940

Test Plan:
-turn off caching temporarily (the cached view is still indented
improperly)
-visit http://phabricator.dev1943.facebook.com/D242591
-note aligned, but not completely highlighted, indentation right above the
comments complaining about
indentation issues

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
Commenters: epriestley
CC: aran, epriestley, grglr
Differential Revision: 174
2011-04-28 16:10:59 -07:00
bin Improve parser scalability, fix a bug or two, provide 'phd', the Phabricator 2011-03-13 14:27:03 -07:00
conf [phabricator] Add mysql slave and read-only database connections 2011-04-28 15:27:19 -07:00
externals Get rid of +x on a bunch of nonexecutable files because I failed to set 2011-04-02 16:47:20 -07:00
resources Differential Updates View 2011-04-28 14:40:41 -07:00
scripts Avoid Timeline race condition 2011-04-14 10:12:10 -07:00
src Differential whitespace mode IGNORE ALL now shows correct indentation 2011-04-28 16:10:59 -07:00
webroot Don't send a new query if the keydown doesn't edit the query value, 2011-04-14 19:17:17 -07:00
.arcconfig Point Phabricator at the meta-install. 2011-02-07 21:57:42 -08:00
.divinerconfig Basic doc for adding/updating Celerity CSS/JS. 2011-03-04 14:15:59 -08:00
.gitignore PhabricatorEnv 2011-01-31 11:55:26 -08:00
README Update the README to be more full of caution. 2011-02-07 12:20:08 -08:00

PROJECT STATUS: CAVEAT EMPTOR

This is an unstable preview release. I'm open sourcing some of Facebook's
internal tools, but they'll be unstable for probably at least a couple months.
-epriestley


WHAT IS PHABRICATOR?

Phabricator is a suite of web applications that facilitate software development
tasks, particularly code review. The primary application in the suite is
Differential, a code review tool.

Phabricator is highly unstable and has many missing features! These applications
are being brought over from Facebook's internal toolset, but there's a lot of
stuff that hasn't made it over yet. Feel free to follow the project but you
probably shouldn't try to install this yet unless you're extremely ambitious
or just want to take a look at it. I'm opening it up now mostly to make it
easier for me to do test deployments outside of Facebook.