mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 12:00:55 +01:00
No description
3fda965288
Summary: Fixes T10876. Currently, we can end up with a setup warning banner sticking on each web device, since the state is stored in local cache. Instead: - When we actually run the setup checks, save the current state in the database. - Before we show a cached banner, make sure the database still says the checks are a problem. This could lead to some inconsistencies if setup checks legitimately pass on some hosts but not on others. For example, if you have `git` installed on one machine but not on another, we may raise a setup warning ("No Git Binary!") about it on one host only. For now, assume users have their operational environments in some sort of reasonable shape and can install the same stuff everywhere. In the future, we could split the issues into "global" and "per-host" issues if we run into problems with this. Test Plan: This is somewhat tricky to test locally since you really need multiple webservers to test it properly, but I: - Created some setup issues, saw banner. - Ignored/cleared them, saw banner go away. - Verified database cache writes were occurring properly. Then I sort of faked it like this: - Created a setup issue. - Manually set the database cache value to `[]` ("no issues"). - Reloaded page. - No more banner. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10876 Differential Revision: https://secure.phabricator.com/D15802 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.