mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
No description
40554e2d8a
Summary: Inline comment anchros were present for all different diffs inside a revision. They were only working for the current diff. Removed the links that were for different diffs. I couldn't get the automatic linking to other diffs working, probably because the anchors didn't work when the page was reloaded. This is also a bit confusing if the diff changes when clicking on anchor. We might want to carry all the comments along in the future, but I don't think it's needed at the moment. Test Plan: Tested on a revision, which had inline comments for differerent diffs that only the comments for the latest diff had anchors when the page was loaded. Changed the diff manually on the page and made sure the anchors for that diff were working correctly and the anchors for the latest diff were not available. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, epriestley Differential Revision: 142 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for probably at least a couple months. -epriestley WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. I'm opening it up now mostly to make it easier for me to do test deployments outside of Facebook.