1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/search
epriestley 76577df506 Extract textual object list parsing from Differential
Summary:
Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like `Reviewers: alincoln, htaft`. Extract, generalize, and cover this.

  - Some of the logic can be simplified with modern ObjectQuery stuff.
  - Make `@username` the formal monogram for users.
  - Make `list@domain.com` the formal monogram for mailing lists.
  - Add test coverage.

Test Plan:
  - Ran unit tests.
  - Called `differential.parsecommitmessage` with a bunch of real-world inputs and got sensible results.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8445
2014-03-07 17:44:44 -08:00
..
application Use ApplicationSearch to power primary search 2014-02-03 12:52:47 -08:00
config Use ApplicationSearch to power primary search 2014-02-03 12:52:47 -08:00
constants Replace "search scope" with selectable default behavior 2014-02-03 14:29:49 -08:00
controller Various linter fixes. 2014-02-26 12:44:58 -08:00
engine Extract textual object list parsing from Differential 2014-03-07 17:44:44 -08:00
index Use ApplicationTransactions/CustomField to power Differential global search 2014-02-26 11:18:06 -08:00
interface Provide PhabricatorSavedQuery to renderResultsList() 2013-07-03 05:46:04 -07:00
management Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
query Fix alternate filtering conditions in object selector dialog 2014-02-11 07:45:33 -08:00
selector Delete license headers from files 2012-11-05 11:16:51 -08:00
storage Partially use ApplicationSearch in main search 2014-02-03 12:51:08 -08:00
view Partially use ApplicationSearch in main search 2014-02-03 12:51:08 -08:00
worker Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00