1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
phorge-phorge/src/applications/differential/view
epriestley 7d0d6fbcf2 Consolidate changeset rendering logic
Summary:
Ref T5179. Currently, all the changeset rendering logic is in the "populate" behavior, and a lot of it comes in via configuration and is hard to get at.

Instead, surface an object which can control it, and which other behaviors can access more easily.

In particular, this allows us to add a "Load/Reload" item to the view options menu, which would previously have been very challenging.

Load/Reload isn't useful on its own, but is a step away from "Show whitespace as...", "Highlight as...", "Show tabtops as...", "View Unified", "View Side-By-Side", etc.

Test Plan:
  - Viewed Differential.
  - Viewed Diffusion.
  - Viewed large changesets, clicked "Load".
  - Used "Load" and "Reload" from view options menu.
  - Loaded all changes in a large diff, verified "Load" and TOC clicks take precedence over other content loads.
  - Played with content stability stuff.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5179

Differential Revision: https://secure.phabricator.com/D9286
2014-06-03 18:01:18 -07:00
..
DifferentialAddCommentView.php Add CCs -> Add Subscribers 2014-06-03 15:53:53 -07:00
DifferentialChangesetDetailView.php Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
DifferentialChangesetFileTreeSideNavBuilder.php [Redesign] Update Filetree CSS 2014-05-29 16:05:51 -07:00
DifferentialChangesetListView.php Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
DifferentialDiffTableOfContentsView.php Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
DifferentialInlineCommentEditView.php Align textarea in diff comment 2014-02-28 08:40:02 -08:00
DifferentialInlineCommentView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialLocalCommitsView.php Differential - modernize "Local Commits" table 2014-04-02 13:18:11 -07:00
DifferentialPrimaryPaneView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialResultsTableView.php Allow CelerityResourceResponse to hold resources from multiple maps 2014-01-02 11:59:35 -08:00
DifferentialReviewersView.php Update PHUIStatusItemView to FontAwesome 2014-05-16 18:59:02 -07:00
DifferentialRevisionDetailView.php Differential Action List on Mobile 2014-04-03 12:01:04 -07:00
DifferentialRevisionListView.php Replace Sprite-Icons with FontAwesome 2014-05-12 10:08:32 -07:00
DifferentialRevisionUpdateHistoryView.php Differential - modernize "Local Commits" table 2014-04-02 13:18:11 -07:00
DifferentialTransactionView.php Make Differential inline comment rendering more consistent and somewhat more modern 2014-02-21 11:52:03 -08:00