1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/differential/field
epriestley ab17a7d4bf Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields
Summary:
Fixes T8360. We will now parse revisions out of "Differential Revision: X" followed by other ad-hoc fields which we do not recognize. Previously, these fields would be treated as part of the value.

(In the general case, other fields may line wrap so we can't assume that fields are only one line long. However, we can make that assumption safely for this field.)

Also maybe fix whatever was going on in T9965 although that didn't really have a reproduction case.

Test Plan: Added unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8360

Differential Revision: https://secure.phabricator.com/D17121
2017-01-01 09:56:02 -08:00
..
__tests__ Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields 2017-01-01 09:56:02 -08:00
DifferentialAuditorsCommitMessageField.php Simplify Auditors custom field in Differential 2016-12-16 10:09:30 -08:00
DifferentialBlameRevisionCommitMessageField.php Move Differential commit message rendering to dedicated classes 2016-12-16 10:08:34 -08:00
DifferentialCommitMessageCustomField.php Make stored custom fields work with v3 EditEngine API 2016-12-16 10:09:03 -08:00
DifferentialCommitMessageField.php Simplify "Tasks" field in Differential 2016-12-16 10:26:34 -08:00
DifferentialConflictsCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialGitSVNIDCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialJIRAIssuesCommitMessageField.php Move Differential commit message rendering to dedicated classes 2016-12-16 10:08:34 -08:00
DifferentialRevertPlanCommitMessageField.php Move Differential commit message rendering to dedicated classes 2016-12-16 10:08:34 -08:00
DifferentialReviewedByCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialReviewersCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialRevisionIDCommitMessageField.php Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields 2017-01-01 09:56:02 -08:00
DifferentialSubscribersCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialSummaryCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialTagsCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialTasksCommitMessageField.php Simplify "Tasks" field in Differential 2016-12-16 10:26:34 -08:00
DifferentialTestPlanCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialTitleCommitMessageField.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00