1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-10-23 17:18:51 +02:00
phorge-phorge/webroot/rsrc/js/application/diff
epriestley d30c3a961c Make the client authoritative for "Cancel" actions
Summary:
Ref T13559. When the user clicks the "Cancel" button, we sometimes take it to mean "delete" (when the comment is empty).

Both the client and server make a decision about this, and they may not agree, which causes the client to fall out of sync.

Make the client responsible for deciding whether it wants to interpret a click on the "Cancel" button as a "revert" or a "delete".

Test Plan: Cancelled empty and nonempty comments, etc. See followup changes.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21649
2021-03-29 09:00:25 -07:00
..
DiffChangeset.js Fix an issue where inlines could be duplicated in the client list 2021-03-29 09:00:23 -07:00
DiffChangesetList.js Make "Open in Editor" use the simple line number of the current selected block 2020-05-21 15:31:16 -07:00
DiffInline.js Make the client authoritative for "Cancel" actions 2021-03-29 09:00:25 -07:00
DiffInlineContentState.js Make client inlines track an "active" state 2021-03-29 09:00:24 -07:00
DiffPathView.js Make "hidden" changesets sticky, and show hidden state in the filetree 2020-04-22 16:12:42 -07:00
DiffTreeView.js Mark "low importance" and "owned" changes in the filetree 2020-04-22 11:22:34 -07:00