1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 09:28:22 +01:00
phorge-phorge/src/applications/fact
Arturas Moskvinas bcf15abcd3 Return empty data if fact dimension is missing, not yet available
Summary:
On fresh installation which doesn't have yet any task closed you will not be able to open charts because of error below:
Fixes:
```
[Mon Oct 21 15:42:41 2019] [2019-10-21 15:42:41] EXCEPTION: (TypeError) Argument 1 passed to head_key() must be of the type array, null given, called in ..phabricator/src/applications/fact/chart/PhabricatorFactChartFunction.php on line 86 at [<phutil>/src/utils/utils.php:832]
[Mon Oct 21 15:42:41 2019]   #0 phlog(TypeError) called at [<phabricator>/src/aphront/handler/PhabricatorAjaxRequestExceptionHandler.php:27]
[Mon Oct 21 15:42:41 2019]   #1 PhabricatorAjaxRequestExceptionHandler::handleRequestThrowable(AphrontRequest, TypeError) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:797]
[Mon Oct 21 15:42:41 2019]   #2 AphrontApplicationConfiguration::handleThrowable(TypeError) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:345]
[Mon Oct 21 15:42:41 2019]   #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:214]
[Mon Oct 21 15:42:41 2019]   #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35
```

To fix issue - lets return empty data set instead

Test Plan:
1) Create fresh phabricator installation
2) Create fresh project
3) Try viewing charts

Reviewers: epriestley, Pawka, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, yelirekim

Differential Revision: https://secure.phabricator.com/D20861
2019-10-30 16:34:22 +02:00
..
application Unprototype "Facts" to clear Maniphest/chart fatals 2019-09-23 13:01:18 -07:00
chart Return empty data if fact dimension is missing, not yet available 2019-10-30 16:34:22 +02:00
controller Unprototype "Facts" to clear Maniphest/chart fatals 2019-09-23 13:01:18 -07:00
daemon Stack chart functions in a more physical way 2019-05-22 05:40:39 -07:00
engine Unprototype "Facts" to clear Maniphest/chart fatals 2019-09-23 13:01:18 -07:00
extract Remove all application callers to "putInSet()" 2018-12-12 16:41:12 -08:00
fact Replace the chart in Maniphest Reports with a chart driven by Facts 2019-05-22 04:44:10 -07:00
management Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
query Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00
storage Store charts earlier and build them out a little later 2019-05-22 05:39:32 -07:00