revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 05:28:18 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/controller
History
epriestley 4310c4ed53 Track a "Done" state on inline comments 
Summary:
Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc.

Specifically, these are the behaviors:

  - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider..").
  - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff.
  - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold:
    - Be consistent with how inlines work.
    - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories.
  - The actual bit where done-ness publishes isn't implemented.
  - UI is bare bones.
  - No integration with the rest of the UI yet.

Test Plan: Clicked some checkboxes.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: paulshen, chasemp, epriestley

Maniphest Tasks: T1460

Differential Revision: https://secure.phabricator.com/D12033
2015-03-24 05:26:11 -07:00
..
DiffusionBranchTableController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionBrowseController.php Have DifferentialRevisionListView return ObjectBoxView 2015-02-19 08:11:17 -08:00
DiffusionBrowseDirectoryController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionBrowseFileController.php Rename inline comment views to "PHUIDiff" and give them a base class 2015-03-06 15:00:14 -08:00
DiffusionBrowseMainController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionBrowseSearchController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionChangeController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionCommitBranchesController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionCommitController.php Change setErrorView to setInfoView in PHUIObjectBoxView 2015-03-06 17:03:18 -08:00
DiffusionCommitEditController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionCommitTagsController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionDiffController.php Track a "Done" state on inline comments 2015-03-24 05:26:11 -07:00
DiffusionExternalController.php Change setErrorView to setInfoView in PHUIObjectBoxView 2015-03-06 17:03:18 -08:00
DiffusionHistoryController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionInlineCommentController.php Track a "Done" state on inline comments 2015-03-24 05:26:11 -07:00
DiffusionInlineCommentPreviewController.php Hide direct accesses to Audit inline comment table behind API 2014-07-24 17:59:28 -07:00
DiffusionLastModifiedController.php Fix a self-XSS hole in Diffusion 2015-03-20 14:54:35 -07:00
DiffusionLintController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionLintDetailsController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionMirrorDeleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionMirrorEditController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionPathCompleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPathTreeController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPathValidateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushEventViewController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionRepositoryCreateController.php Set "importing" flag on repositories created via API 2015-03-04 10:36:09 -08:00
DiffusionRepositoryDefaultController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditActionsController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditActivateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditBasicController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditBranchesController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditController.php Fix method visibility for PhabricatorController subclasses 2015-01-07 07:34:59 +11:00
DiffusionRepositoryEditDangerousController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditDeleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditEncodingController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditHostingController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditMainController.php Add "phabricator.silent" for stopping all outbound events from an install 2015-03-18 07:09:43 -07:00
DiffusionRepositoryEditStorageController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditSubversionController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditUpdateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryListController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryNewController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionServeController.php Proxy VCS HTTP requests 2015-01-27 14:51:09 -08:00
DiffusionSymbolController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionTagListController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00