1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 15:22:41 +01:00
phorge-phorge/src/infrastructure
epriestley 4310c4ed53 Track a "Done" state on inline comments
Summary:
Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc.

Specifically, these are the behaviors:

  - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider..").
  - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff.
  - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold:
    - Be consistent with how inlines work.
    - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories.
  - The actual bit where done-ness publishes isn't implemented.
  - UI is bare bones.
  - No integration with the rest of the UI yet.

Test Plan: Clicked some checkboxes.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: paulshen, chasemp, epriestley

Maniphest Tasks: T1460

Differential Revision: https://secure.phabricator.com/D12033
2015-03-24 05:26:11 -07:00
..
customfield Show change details for "Remarkup" standard custom field edits 2015-03-03 10:39:32 -08:00
daemon Increase the visibility of permanent task failures in task queue 2015-03-15 13:27:05 -07:00
diff Track a "Done" state on inline comments 2015-03-24 05:26:11 -07:00
edges Modernize remaining edge types 2015-01-03 10:58:20 +11:00
env Improve granluarity and defaults of security.allow-outbound-http 2015-03-23 10:44:03 -07:00
events Add a "did verify email" event to Phabricator 2015-02-11 14:39:06 -08:00
internationalization Improve translation of some file strings 2015-03-15 11:37:30 -07:00
javelin Allow Javelin initBehavior to source alternative library behaviors 2014-11-04 06:47:07 -08:00
lint/linter Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
log Explicitly declare method/property visibility 2015-01-12 08:18:13 +11:00
management Add some of a billing daemon skeleton 2015-01-30 11:29:05 -08:00
markup Improve granluarity and defaults of security.allow-outbound-http 2015-03-23 10:44:03 -07:00
query Allow repositories to be ordered by commit count 2015-03-23 09:10:34 -07:00
sms Add "phabricator.silent" for stopping all outbound events from an install 2015-03-18 07:09:43 -07:00
ssh Proxy VCS SSH requests 2015-01-28 14:41:24 -08:00
storage Add a storage renamespace for mangling SQL dumpfiles into a new namespace 2015-03-17 18:29:01 -07:00
testing Add "phabricator.silent" for stopping all outbound events from an install 2015-03-18 07:09:43 -07:00
time Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
util Improve Phriction page move dialog 2014-11-12 07:04:51 -08:00
PhabricatorEditor.php Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00