mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-18 21:02:41 +01:00
431c57688e
Summary: D477 added functionality to the project list view but had a couple of performance issues that I missed in review, because it took the query count for the page from around 3 to as many as 300, including up to 100 heavyweight search index queries. This fixes the two simple N+1 query problems. This general pattern of data access often occurs: COUNTEREXAMPLE $cats = load_cats(); foreach ($cats as $cat) { $cats_hats = load_hats_for_cat($cat); // ... } But this issues "N+1" queries, i.e. if you load 100 cats you issue 101 queries. It is faster to group the queries instead: $cats = load_cats(); $hats = load_all_hats_for_these_cats($cats); foreach ($cats as $cat) { $cats_hats = $hats[$cat->getID()]; } MySQL can execute one query which returns all the results much faster than 100 queries which return one result, especially if the database is not local (i.e., over the network). However, this doesn't save a ton of time. The bigger issue is that I didn't have the right keys on the relationship tables in the search engine. This adds them, and reduces the search engine lookup cost from 25-80ms (for secure.phabricator.com) down to 1-3ms. I still probably want to get this out of the loop at some point but it's okay for now and the page loads in a few ms rather than taking more than a second. Test Plan: Used "services" tab, "xhprof" and "EXPLAIN" to analyze page performance. I measured these changes: - Query count: 1 + (3 * N projects) -> 3 + (N projects) (e.g., 301 -> 103) - Total time spent querying, ignoring search indexes: 40ms (local.aprhont.com) -> 20ms (local.aphront.com) - Cost for search index query: 25-80ms (secure.phabricator.com) -> 1-3ms Reviewed By: cadamo Reviewers: cadamo, aran, jungejason, tuomaspelkonen CC: aran, cadamo, epriestley Differential Revision: 485 |
||
|---|---|---|
| .. | ||
| 000.project.sql | ||
| 001.maniphest_projects.sql | ||
| 002.oauth.sql | ||
| 003.more_oauth.sql | ||
| 004.daemonrepos.sql | ||
| 005.workers.sql | ||
| 006.repository.sql | ||
| 007.daemonlog.sql | ||
| 008.repoopt.sql | ||
| 009.repo_summary.sql | ||
| 010.herald.sql | ||
| 011.badcommit.sql | ||
| 012.dropphidtype.sql | ||
| 013.commitdetail.sql | ||
| 014.shortcuts.sql | ||
| 015.preferences.sql | ||
| 016.userrealnameindex.sql | ||
| 017.sessionkeys.sql | ||
| 018.owners.sql | ||
| 019.arcprojects.sql | ||
| 020.pathcapital.sql | ||
| 021.xhpastview.sql | ||
| 022.differentialcommit.sql | ||
| 023.dxkeys.sql | ||
| 024.mlistkeys.sql | ||
| 025.commentopt.sql | ||
| 026.diffpropkey.sql | ||
| 027.metamtakeys.sql | ||
| 028.systemagent.sql | ||
| 029.cursors.sql | ||
| 030.imagemacro.sql | ||
| 031.workerrace.sql | ||
| 032.viewtime.sql | ||
| 033.privtest.sql | ||
| 034.savedheader.sql | ||
| 035.proxyimage.sql | ||
| 036.mailkey.sql | ||
| 037.setuptest.sql | ||
| 038.admin.sql | ||
| 039.userlog.sql | ||
| 040.transform.sql | ||
| 041.heraldrepetition.sql | ||
| 042.commentmetadata.sql | ||
| 043.pastebin.sql | ||
| 044.countdown.sql | ||
| 045.timezone.sql | ||
| 046.conduittoken.sql | ||
| 047.projectstatus.sql | ||
| 048.relationshipkeys.sql | ||