mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-03 04:02:43 +01:00
43ff24b0f3
Summary: This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things: - Font Styles are correctly applied for form elements now. - Everything lines up! - Selects are larger, easier to read, interact. - Inputs have been squared. - Consistant CSS applied glow (try it!) - Improved Mobile Responsiveness - CSS applied to all form elements, not just Aphront - Many other minor tweaks. I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try. Test Plan: Tested many applications, forms, mobile and tablet. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5860
85 lines
2.4 KiB
PHP
85 lines
2.4 KiB
PHP
<?php
|
|
|
|
final class DifferentialDiffCreateController extends DifferentialController {
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
|
|
if ($request->isFormPost()) {
|
|
$diff = null;
|
|
|
|
if ($request->getFileExists('diff-file')) {
|
|
$diff = PhabricatorFile::readUploadedFileData($_FILES['diff-file']);
|
|
} else {
|
|
$diff = $request->getStr('diff');
|
|
}
|
|
|
|
$call = new ConduitCall(
|
|
'differential.createrawdiff',
|
|
array(
|
|
'diff' => $diff,
|
|
));
|
|
$call->setUser($request->getUser());
|
|
$result = $call->execute();
|
|
|
|
$path = id(new PhutilURI($result['uri']))->getPath();
|
|
return id(new AphrontRedirectResponse())->setURI($path);
|
|
}
|
|
|
|
$form = new AphrontFormView();
|
|
$form->setFlexible(true);
|
|
$arcanist_href = PhabricatorEnv::getDoclink(
|
|
'article/Arcanist_User_Guide.html');
|
|
$arcanist_link = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $arcanist_href,
|
|
'target' => '_blank',
|
|
),
|
|
'Arcanist');
|
|
$form
|
|
->setAction('/differential/diff/create/')
|
|
->setEncType('multipart/form-data')
|
|
->setUser($request->getUser())
|
|
->appendChild(hsprintf(
|
|
'<p class="aphront-form-instructions">%s</p>',
|
|
pht(
|
|
'The best way to create a Differential diff is by using %s, but you '.
|
|
'can also just paste a diff (e.g., from %s or %s) into this box '.
|
|
'or upload it as a file if you really want.',
|
|
$arcanist_link,
|
|
phutil_tag('tt', array(), 'svn diff'),
|
|
phutil_tag('tt', array(), 'git diff'))))
|
|
->appendChild(
|
|
id(new AphrontFormTextAreaControl())
|
|
->setLabel(pht('Raw Diff'))
|
|
->setName('diff')
|
|
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL))
|
|
->appendChild(
|
|
id(new AphrontFormFileControl())
|
|
->setLabel(pht('Raw Diff from file'))
|
|
->setName('diff-file'))
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht("Create Diff \xC2\xBB")));
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('Create Diff'))
|
|
->setHref('/differential/diff/create/'));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$form
|
|
),
|
|
array(
|
|
'title' => pht('Create Diff'),
|
|
'device' => true,
|
|
'dust' => true,
|
|
));
|
|
}
|
|
|
|
}
|