1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 4425903480 Don't require phabricator.base-uri to be configured
Summary:
Fixes T2293.

We currently hard-require this in setup. We do not need to; we don't actually need it until we start running daemons. Move it to post-install and provide more guidance.

We could make this even easier in the future, but we'd need to special case it, since it's dangerous to let it be set to any value (if you set it to the wrong value, you can't log in). We could safely have a workflow which writes the current request URI into the database configuration, or a two-stage workflow where we set the URI and then verify it, but these both imply some special casing and complication. This should be a step forward from where we are today, regardless.

Test Plan:
Removed "phabricator.base-uri" from my configuration. Verified Phabricator still works.

Without "phabricator.base-uri" configured, logged in from multiple host names (127.0.0.1:8080, local.aphront.com:8080).

Configured "phabricator.base-uri". Verified my unblessed session no longer worked. Verified setup issue went away.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2293

Differential Revision: https://secure.phabricator.com/D4580
2013-01-22 13:57:02 -08:00
..
aphront Ability to "Create X" from wide sidebar buttons 2013-01-22 09:06:57 -08:00
application Don't require phabricator.base-uri to be configured 2013-01-22 13:57:02 -08:00
core Show a warning banner to administrators when there are unresolved setup warnings 2013-01-17 16:25:47 -08:00
layout Fix FileTreeView sprites 2013-01-22 09:10:21 -08:00
sprite-apps-large.css Added Feed icons. 2013-01-10 10:00:18 -08:00
sprite-apps-xlarge.css Added Feed icons. 2013-01-10 10:00:18 -08:00
sprite-apps.css Added Feed icons. 2013-01-10 10:00:18 -08:00
sprite-gradient.css Fix FileTreeView sprites 2013-01-22 09:10:21 -08:00
sprite-icon.css Use white "+" icon for homepage tile hoverstate 2013-01-22 09:56:18 -08:00
sprite-menu.css Clean up some more sprite stuff 2012-12-07 14:29:09 -08:00