1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 16:16:14 +01:00
phorge-phorge/src/applications/harbormaster/engine
epriestley f97df9ebea Implement Build Plan behavior "Affects Buildable"
Summary: Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan:
  - As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  - Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  - "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  - "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

{F6250359}

  - "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

{F6250360}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13258

Differential Revision: https://secure.phabricator.com/D20233
2019-03-06 06:30:09 -08:00
..
HarbormasterBuildableEngine.php Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
HarbormasterBuildEngine.php Implement Build Plan behavior "Affects Buildable" 2019-03-06 06:30:09 -08:00
HarbormasterBuildGraph.php Remove obsolete, confusing Harbormaster builds steps 2016-02-26 10:34:58 -08:00
HarbormasterBuildRequest.php add initiator.phid parameter to HM builds 2015-11-04 18:32:18 +00:00
HarbormasterMessageType.php Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write 2018-02-12 12:18:52 -08:00
HarbormasterTargetEngine.php add initiator.phid parameter to HM builds 2015-11-04 18:32:18 +00:00