mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-21 04:01:30 +01:00
63e6b2553e
Summary: Ref T2543. When a revision is created, we check if any builds are waiting/failed, and submit it for review immediately if we aren't waiting for anything. In doing this, we ignore builds with only autotargets, since these are client-side and failures from local `arc lint` / `arc unit` should not count (the user has already chosen to ignore/skip them). The way we do this has some issues: - Herald may have started builds, but they may still be PENDING and not have any targets yet. In this case, we'll see "no non-autotargets" and ignore the build, which is wrong. - We have to load targets but don't really care about them, which is more work than we really need to do. - And it's kind of complex, too. Instead, just let `BuildQuery` filter out "autobuilds" (builds generated from autoplans) with a JOIN. Test Plan: Ran `arc diff` with builds configured, got a clean "Draft" state instead of an incorrect promotion directly to "Needs Review". Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18721
233 lines
5.7 KiB
PHP
233 lines
5.7 KiB
PHP
<?php
|
|
|
|
final class HarbormasterBuildQuery
|
|
extends PhabricatorCursorPagedPolicyAwareQuery {
|
|
|
|
private $ids;
|
|
private $phids;
|
|
private $buildStatuses;
|
|
private $buildablePHIDs;
|
|
private $buildPlanPHIDs;
|
|
private $initiatorPHIDs;
|
|
private $needBuildTargets;
|
|
private $autobuilds;
|
|
|
|
public function withIDs(array $ids) {
|
|
$this->ids = $ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withPHIDs(array $phids) {
|
|
$this->phids = $phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withBuildStatuses(array $build_statuses) {
|
|
$this->buildStatuses = $build_statuses;
|
|
return $this;
|
|
}
|
|
|
|
public function withBuildablePHIDs(array $buildable_phids) {
|
|
$this->buildablePHIDs = $buildable_phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withBuildPlanPHIDs(array $build_plan_phids) {
|
|
$this->buildPlanPHIDs = $build_plan_phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withInitiatorPHIDs(array $initiator_phids) {
|
|
$this->initiatorPHIDs = $initiator_phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withAutobuilds($with_autobuilds) {
|
|
$this->autobuilds = $with_autobuilds;
|
|
return $this;
|
|
}
|
|
|
|
public function needBuildTargets($need_targets) {
|
|
$this->needBuildTargets = $need_targets;
|
|
return $this;
|
|
}
|
|
|
|
public function newResultObject() {
|
|
return new HarbormasterBuild();
|
|
}
|
|
|
|
protected function loadPage() {
|
|
return $this->loadStandardPage($this->newResultObject());
|
|
}
|
|
|
|
protected function willFilterPage(array $page) {
|
|
$buildables = array();
|
|
|
|
$buildable_phids = array_filter(mpull($page, 'getBuildablePHID'));
|
|
if ($buildable_phids) {
|
|
$buildables = id(new PhabricatorObjectQuery())
|
|
->setViewer($this->getViewer())
|
|
->withPHIDs($buildable_phids)
|
|
->setParentQuery($this)
|
|
->execute();
|
|
$buildables = mpull($buildables, null, 'getPHID');
|
|
}
|
|
|
|
foreach ($page as $key => $build) {
|
|
$buildable_phid = $build->getBuildablePHID();
|
|
if (empty($buildables[$buildable_phid])) {
|
|
unset($page[$key]);
|
|
continue;
|
|
}
|
|
$build->attachBuildable($buildables[$buildable_phid]);
|
|
}
|
|
|
|
return $page;
|
|
}
|
|
|
|
protected function didFilterPage(array $page) {
|
|
$plans = array();
|
|
|
|
$plan_phids = array_filter(mpull($page, 'getBuildPlanPHID'));
|
|
if ($plan_phids) {
|
|
$plans = id(new PhabricatorObjectQuery())
|
|
->setViewer($this->getViewer())
|
|
->withPHIDs($plan_phids)
|
|
->setParentQuery($this)
|
|
->execute();
|
|
$plans = mpull($plans, null, 'getPHID');
|
|
}
|
|
|
|
foreach ($page as $key => $build) {
|
|
$plan_phid = $build->getBuildPlanPHID();
|
|
$build->attachBuildPlan(idx($plans, $plan_phid));
|
|
}
|
|
|
|
$build_phids = mpull($page, 'getPHID');
|
|
$commands = id(new HarbormasterBuildCommand())->loadAllWhere(
|
|
'targetPHID IN (%Ls) ORDER BY id ASC',
|
|
$build_phids);
|
|
$commands = mgroup($commands, 'getTargetPHID');
|
|
foreach ($page as $build) {
|
|
$unprocessed_commands = idx($commands, $build->getPHID(), array());
|
|
$build->attachUnprocessedCommands($unprocessed_commands);
|
|
}
|
|
|
|
if ($this->needBuildTargets) {
|
|
$targets = id(new HarbormasterBuildTargetQuery())
|
|
->setViewer($this->getViewer())
|
|
->setParentQuery($this)
|
|
->withBuildPHIDs($build_phids)
|
|
->execute();
|
|
|
|
// TODO: Some day, when targets have dependencies, we should toposort
|
|
// these. For now, just put them into chronological order.
|
|
$targets = array_reverse($targets);
|
|
|
|
$targets = mgroup($targets, 'getBuildPHID');
|
|
foreach ($page as $build) {
|
|
$build_targets = idx($targets, $build->getPHID(), array());
|
|
|
|
foreach ($build_targets as $phid => $target) {
|
|
if ($target->getBuildGeneration() !== $build->getBuildGeneration()) {
|
|
unset($build_targets[$phid]);
|
|
}
|
|
}
|
|
|
|
$build->attachBuildTargets($build_targets);
|
|
}
|
|
}
|
|
|
|
return $page;
|
|
}
|
|
|
|
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
|
|
$where = parent::buildWhereClauseParts($conn);
|
|
|
|
if ($this->ids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.id IN (%Ld)',
|
|
$this->ids);
|
|
}
|
|
|
|
if ($this->phids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.phid in (%Ls)',
|
|
$this->phids);
|
|
}
|
|
|
|
if ($this->buildStatuses !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.buildStatus in (%Ls)',
|
|
$this->buildStatuses);
|
|
}
|
|
|
|
if ($this->buildablePHIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.buildablePHID IN (%Ls)',
|
|
$this->buildablePHIDs);
|
|
}
|
|
|
|
if ($this->buildPlanPHIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.buildPlanPHID IN (%Ls)',
|
|
$this->buildPlanPHIDs);
|
|
}
|
|
|
|
if ($this->initiatorPHIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'b.initiatorPHID IN (%Ls)',
|
|
$this->initiatorPHIDs);
|
|
}
|
|
|
|
if ($this->autobuilds !== null) {
|
|
if ($this->autobuilds) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'p.planAutoKey IS NOT NULL');
|
|
} else {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'p.planAutoKey IS NULL');
|
|
}
|
|
}
|
|
|
|
return $where;
|
|
}
|
|
|
|
protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
|
|
$joins = parent::buildJoinClauseParts($conn);
|
|
|
|
if ($this->shouldJoinPlanTable()) {
|
|
$joins[] = qsprintf(
|
|
$conn,
|
|
'JOIN %T p ON b.buildPlanPHID = p.phid',
|
|
id(new HarbormasterBuildPlan())->getTableName());
|
|
}
|
|
|
|
return $joins;
|
|
}
|
|
|
|
private function shouldJoinPlanTable() {
|
|
if ($this->autobuilds !== null) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
public function getQueryApplicationClass() {
|
|
return 'PhabricatorHarbormasterApplication';
|
|
}
|
|
|
|
protected function getPrimaryTableAlias() {
|
|
return 'b';
|
|
}
|
|
|
|
}
|