1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-09 22:31:03 +01:00
phorge-phorge/src/applications/harbormaster/view
epriestley cc8cbed029 Make "DifferentialDiff->properties" a proper "attachable" property
Summary:
See PHI498. This should be initialized to "self::ATTACHABLE" like other attachable properties, but is currently initialized to "array()".

Initialize it the normal way and try to catch all code paths which may have accessed it without actually loading and attaching it.

Also, remove UI for the very old "excuse" property, which "arc" has not written for well more than a year.

Test Plan: Grepped for affected symbols, loaded various revision pages. Somewhat tricky to be 100% sure that every pathway is caught, but it should be obvious if I missed anything once someone hits the code path.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D21710
2021-07-27 13:39:12 -07:00
..
HarbormasterBuildLogView.php Share the Paste line highlighting behavior for Harbormaster build logs 2018-03-01 12:57:30 -08:00
HarbormasterBuildView.php Fix an issue where builds with no initiator failed to render in build plans 2020-05-19 09:46:18 -07:00
HarbormasterLintPropertyView.php Improve lint/unit limit, sort, view all, collapse behaviors 2015-06-23 13:34:25 -07:00
HarbormasterUnitPropertyView.php In summary interfaces, don't render very large inline remarkup details for unit test messages 2020-02-05 14:26:38 -08:00
HarbormasterUnitSummaryView.php Make "DifferentialDiff->properties" a proper "attachable" property 2021-07-27 13:39:12 -07:00
ShellLogView.php Fix the legacy "25, 50, 100, unlimited" Harbormaster log links to respect generation selection 2018-04-13 11:55:44 -07:00