mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
ef85f49adc
Summary: This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory). We are removing the headers for these reasons: - It wastes space in editors, less code is visible in editor upon opening a file. - It brings noise to diff of the first change of any file every year. - It confuses Git file copy detection when creating small files. - We don't have an explicit license header in other files (JS, CSS, images, documentation). - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new. This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook). Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals. Reviewers: epriestley, davidrecordon Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2035 Differential Revision: https://secure.phabricator.com/D3886
86 lines
2.6 KiB
PHP
86 lines
2.6 KiB
PHP
<?php
|
|
|
|
final class DifferentialCommentSaveController extends DifferentialController {
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
if (!$request->isFormPost()) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$revision_id = $request->getInt('revision_id');
|
|
$revision = id(new DifferentialRevision())->load($revision_id);
|
|
if (!$revision) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$comment = $request->getStr('comment');
|
|
$action = $request->getStr('action');
|
|
$reviewers = $request->getArr('reviewers');
|
|
$ccs = $request->getArr('ccs');
|
|
|
|
$editor = new DifferentialCommentEditor(
|
|
$revision,
|
|
$action);
|
|
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_WEB,
|
|
array(
|
|
'ip' => $request->getRemoteAddr(),
|
|
));
|
|
|
|
try {
|
|
$editor
|
|
->setActor($request->getUser())
|
|
->setMessage($comment)
|
|
->setContentSource($content_source)
|
|
->setAttachInlineComments(true)
|
|
->setAddedReviewers($reviewers)
|
|
->setAddedCCs($ccs)
|
|
->save();
|
|
} catch (DifferentialActionHasNoEffectException $no_effect) {
|
|
$has_inlines = id(new DifferentialInlineComment())->loadAllWhere(
|
|
'authorPHID = %s AND revisionID = %d AND commentID IS NULL',
|
|
$request->getUser()->getPHID(),
|
|
$revision->getID());
|
|
|
|
$dialog = new AphrontDialogView();
|
|
$dialog->setUser($request->getUser());
|
|
$dialog->addCancelButton('/D'.$revision_id);
|
|
|
|
$dialog->addHiddenInput('revision_id', $revision_id);
|
|
$dialog->addHiddenInput('action', 'none');
|
|
$dialog->addHiddenInput('reviewers', $reviewers);
|
|
$dialog->addHiddenInput('ccs', $ccs);
|
|
$dialog->addHiddenInput('comment', $comment);
|
|
|
|
$dialog->setTitle('Action Has No Effect');
|
|
$dialog->appendChild(
|
|
'<p>'.phutil_escape_html($no_effect->getMessage()).'</p>');
|
|
|
|
if (strlen($comment) || $has_inlines) {
|
|
$dialog->addSubmitButton('Post as Comment');
|
|
$dialog->appendChild('<br />');
|
|
$dialog->appendChild(
|
|
'<p>Do you want to post your feedback anyway, as a normal '.
|
|
'comment?</p>');
|
|
}
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
// TODO: Diff change detection?
|
|
|
|
$draft = id(new PhabricatorDraft())->loadOneWhere(
|
|
'authorPHID = %s AND draftKey = %s',
|
|
$request->getUser()->getPHID(),
|
|
'differential-comment-'.$revision->getID());
|
|
if ($draft) {
|
|
$draft->delete();
|
|
}
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/D'.$revision->getID());
|
|
}
|
|
|
|
}
|