1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/transactions/editfield
epriestley 35750b9c61 Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
Summary:
Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan:
  - Selected "Accept", then selected "Reject". One replaced the other.
  - Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17132
2017-01-02 13:25:12 -08:00
..
PhabricatorApplyEditField.php Make some Differential comment actions (like "Accept" and "Reject") conflict with one another 2017-01-02 13:25:12 -08:00
PhabricatorBoolEditField.php Make the "All Day Event" control use a checkbox instead of a dropdown 2016-10-31 14:18:59 -07:00
PhabricatorColumnsEditField.php Implement a rough optgroup-based "Move on Workboard" stacked action 2016-04-06 09:15:12 -07:00
PhabricatorCommentEditField.php Allow the new Differential EditEngine form to create/update diffs for revisions 2016-12-14 07:27:25 -08:00
PhabricatorConduitEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorDatasourceEditField.php Modularize application extensions to EditEngine 2015-11-30 08:59:27 -08:00
PhabricatorDividerEditField.php Allow the new Differential EditEngine form to create/update diffs for revisions 2016-12-14 07:27:25 -08:00
PhabricatorEditField.php Allow comment actions to be grouped; group Differential "Review" and "Revision" actions 2016-12-31 10:09:41 -08:00
PhabricatorEpochEditField.php Hide time controls when editing all-day Calendar events 2016-07-27 05:01:19 -07:00
PhabricatorFileEditField.php Make Calendar ICS imports sort of work in a crude, approximate way 2016-10-12 15:29:05 -07:00
PhabricatorHandlesEditField.php Replace workboard task creation with EditEngine 2015-12-08 17:56:11 -08:00
PhabricatorIconSetEditField.php Convert projects to EditEngine 2015-12-27 15:42:50 -08:00
PhabricatorInstructionsEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorPHIDListEditField.php Improve behavior of "owner" transaction in "maniphest.edit" endpoint 2016-01-11 09:19:18 -08:00
PhabricatorPointsEditField.php Support enabling a formal points field in Maniphest 2016-02-08 18:14:44 -08:00
PhabricatorPolicyEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorProjectsEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorRemarkupEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorSelectEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorSpaceEditField.php Prevent "Spaces" field from being set to inconsistent values 2015-12-17 11:22:32 -08:00
PhabricatorStaticEditField.php Convert DrydockBlueprints to EditEngine 2016-03-03 15:21:25 -08:00
PhabricatorStringListEditField.php Fix smushing of multiple values in Projects "Additional Hashtags" field 2016-01-18 08:34:13 -08:00
PhabricatorSubmitEditField.php Allow the new Differential EditEngine form to create/update diffs for revisions 2016-12-14 07:27:25 -08:00
PhabricatorSubscribersEditField.php Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
PhabricatorTextAreaEditField.php Fix an issue with TextAreaEditField affecting Paste 2016-05-11 15:35:17 -07:00
PhabricatorTextEditField.php Make "profile menu" configuration mostly work 2016-01-13 11:45:31 -08:00
PhabricatorTokenizerEditField.php Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions 2015-12-15 15:03:34 -08:00
PhabricatorUsersEditField.php Improve behavior of "owner" transaction in "maniphest.edit" endpoint 2016-01-11 09:19:18 -08:00