mirror of
https://we.phorge.it/source/phorge.git
synced 2025-03-30 22:18:13 +02:00
458ad4a861
Summary: The history query for the repository page isn't actually used to display any content. It looks like it was previously used to display the last user which modified a file however this looks to be removed in D21404. This removes the history query from happening as well as updates `DiffusionBrowseTableView` to remove the parameters for passing this information in, resulting in also updating `DiffusionBrowseController` to no longer need to put this information together. Refs T13666 Test Plan: 1. I removed commits from a repository on the local state. 2. I navigated to the repository's landing page and saw that the landing page attempted to render content and only failed to load the browse files section. 3. I navigated to the history tab and verified that it showed an exception about failing to query commit information. 4. I restored the repository working state to function properly. 5. I navigated to a repository's landing page and verified it loaded properly, including showing the last modified date for each file. 6. I navigated to the Code, Branches, Tags, and History tabs to verify each tab page loaded properly. 7. I verified on the Code tab that the last modified date for each file displayed properly. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T13666 Differential Revision: https://secure.phabricator.com/D21717
137 lines
3.3 KiB
PHP
137 lines
3.3 KiB
PHP
<?php
|
|
|
|
final class DiffusionBrowseTableView extends DiffusionView {
|
|
|
|
private $paths;
|
|
|
|
public function setPaths(array $paths) {
|
|
assert_instances_of($paths, 'DiffusionRepositoryPath');
|
|
$this->paths = $paths;
|
|
return $this;
|
|
}
|
|
|
|
public function render() {
|
|
$request = $this->getDiffusionRequest();
|
|
$repository = $request->getRepository();
|
|
require_celerity_resource('diffusion-css');
|
|
|
|
$base_path = trim($request->getPath(), '/');
|
|
if ($base_path) {
|
|
$base_path = $base_path.'/';
|
|
}
|
|
|
|
$need_pull = array();
|
|
$rows = array();
|
|
foreach ($this->paths as $path) {
|
|
$full_path = $base_path.$path->getPath();
|
|
|
|
$dir_slash = null;
|
|
$file_type = $path->getFileType();
|
|
if ($file_type == DifferentialChangeType::FILE_DIRECTORY) {
|
|
$browse_text = $path->getPath().'/';
|
|
$dir_slash = '/';
|
|
|
|
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
|
|
$full_path.$dir_slash,
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
)));
|
|
|
|
$history_path = $full_path.'/';
|
|
} else if ($file_type == DifferentialChangeType::FILE_SUBMODULE) {
|
|
$browse_text = $path->getPath().'/';
|
|
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
|
|
null,
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
'hash' => $path->getHash(),
|
|
'external' => $path->getExternalURI(),
|
|
)));
|
|
|
|
$history_path = $full_path.'/';
|
|
} else {
|
|
$browse_text = $path->getPath();
|
|
$browse_link = $this->linkBrowse(
|
|
$full_path,
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
));
|
|
|
|
$history_path = $full_path;
|
|
}
|
|
|
|
$history_link = $this->linkHistory($history_path);
|
|
|
|
$dict = array(
|
|
'lint' => celerity_generate_unique_node_id(),
|
|
'date' => celerity_generate_unique_node_id(),
|
|
'details' => celerity_generate_unique_node_id(),
|
|
);
|
|
|
|
$need_pull[$full_path.$dir_slash] = $dict;
|
|
foreach ($dict as $k => $uniq) {
|
|
$dict[$k] = phutil_tag('span', array('id' => $uniq), '');
|
|
}
|
|
|
|
$rows[] = array(
|
|
$browse_link,
|
|
idx($dict, 'lint'),
|
|
$dict['details'],
|
|
$dict['date'],
|
|
$history_link,
|
|
);
|
|
|
|
}
|
|
|
|
if ($need_pull) {
|
|
Javelin::initBehavior(
|
|
'diffusion-pull-lastmodified',
|
|
array(
|
|
'uri' => (string)$request->generateURI(
|
|
array(
|
|
'action' => 'lastmodified',
|
|
'stable' => true,
|
|
)),
|
|
'map' => $need_pull,
|
|
));
|
|
}
|
|
|
|
$branch = $this->getDiffusionRequest()->loadBranch();
|
|
$show_lint = ($branch && $branch->getLintCommit());
|
|
$lint = $request->getLint();
|
|
|
|
$view = new AphrontTableView($rows);
|
|
$view->setColumnClasses(
|
|
array(
|
|
'',
|
|
'',
|
|
'wide commit-detail',
|
|
'right',
|
|
'right narrow',
|
|
));
|
|
$view->setColumnVisibility(
|
|
array(
|
|
true,
|
|
$show_lint,
|
|
true,
|
|
true,
|
|
true,
|
|
));
|
|
|
|
$view->setDeviceVisibility(
|
|
array(
|
|
true,
|
|
false,
|
|
false,
|
|
false,
|
|
false,
|
|
));
|
|
|
|
|
|
return phutil_tag_div('diffusion-browse-table', $view->render());
|
|
}
|
|
|
|
}
|