mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-02 01:48:23 +01:00
No description
4682e0c104
Summary: I make this error quite often: I forget to declare a property I am writing to or I make a typo in it. PHP implicitly creates a public property which I don't like. I would much rather see a linter warning me against this than this runtime check but writing it is very difficult: - We need to explore all parents of the class we are checking. - It is even possible that children will declare that property but it's OK to treat this as error anyway. - We can extend also builtin or external classes. - It's somewhat doable for `$this` but even more complex for any `$obj` because we don't know the class of it. This should catch significant part of these errors and I'm fine with that. I don't plan escalating to exception because this error is not fatal and should not stop the application from working. Test Plan: Loaded homepage, checked log. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3601 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support/aphlict | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| .gitmodules | ||
| README | ||
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0