1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 12:42:43 +01:00
phorge-phorge/src/applications/diffusion/controller
epriestley 46d1596bf7 Pull legacy revision query status filters out of the main Query class
Summary:
Ref T2543. Currently, Differential uses a set of hard-coded query filters (like "open" and "closed") to query revisions by status (for example, "open" means any of "review, revision, changes planned, accepted [usually]").

In other applications, like Maniphest, we've replaced this with a low level list of the actual statuses, plus higher level convenience UI through tokenizer functions. This basically has all of the benefits of the hard-coded filters with none of the drawbacks, and is generally more flexible.

I'd like to do that in Differential, too, although we'll need to keep the legacy maps around for a while because they're used by `differential.find` and `differential.getrevision`. To prepare for this, pull all the legacy stuff out into a separate class. Then I'll modernize where I can, and we can get rid of this junk some day.

Test Plan: Grepped for `RevisionQuery::STATUS`. Ran queries via Differential UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18343
2017-08-09 11:06:15 -07:00
..
DiffusionBranchTableController.php Add tabs to Diffusion for consistent navigation 2017-07-05 22:09:36 +01:00
DiffusionBrowseController.php Pull legacy revision query status filters out of the main Query class 2017-08-09 11:06:15 -07:00
DiffusionChangeController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionCloneController.php Move Clone Repository to Dialog 2017-07-11 13:16:47 -07:00
DiffusionCommitBranchesController.php Show first 10 branches, then "More Branches" for commits on huge numbers of branches 2016-02-16 15:10:01 -08:00
DiffusionCommitController.php Move most Differetial keyboard shortcuts into DiffChangesetList 2017-05-16 06:24:42 -07:00
DiffusionCommitEditController.php Replace old commit edit controller with new EditEngine controller 2017-01-11 10:37:53 -08:00
DiffusionCommitListController.php Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
DiffusionCommitTagsController.php Show first 10 branches, then "More Branches" for commits on huge numbers of branches 2016-02-16 15:10:01 -08:00
DiffusionCompareController.php Attach Diffusion Pagers to their ObjectBoxView 2017-04-21 11:22:19 -07:00
DiffusionController.php Add tabs to Diffusion for consistent navigation 2017-07-05 22:09:36 +01:00
DiffusionDiffController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionExternalController.php Fix two issues with callsign-free repositories 2016-02-26 06:13:46 -08:00
DiffusionGraphController.php Add tabs to Diffusion for consistent navigation 2017-07-05 22:09:36 +01:00
DiffusionHistoryController.php Add tabs to Diffusion for consistent navigation 2017-07-05 22:09:36 +01:00
DiffusionInlineCommentController.php Correctly clear draft markers when deleting an inline comment 2015-07-21 11:36:46 -07:00
DiffusionInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00
DiffusionLastModifiedController.php Simplify Diffusion Browse Table 2017-07-09 09:43:57 -07:00
DiffusionLintController.php Attach Diffusion Pagers to their ObjectBoxView 2017-04-21 11:22:19 -07:00
DiffusionPathCompleteController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathTreeController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathValidateController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPushEventViewController.php Fix an issue with PHID/handle management in push logs 2016-04-20 04:47:10 -07:00
DiffusionPushLogController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRefTableController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryController.php Add a branch selector to Diffusion 2017-07-24 13:41:23 -07:00
DiffusionRepositoryDefaultController.php Redirect /source/x (no slash) to /source/x/ (canonical) when viewer is logged out and "x" is public 2016-12-20 07:48:20 -08:00
DiffusionRepositoryEditActivateController.php Provide more UI guidance when creating repositories 2016-05-11 06:35:35 -07:00
DiffusionRepositoryEditController.php Add a strong hint about importing or observing repositories to repository creation 2016-07-08 07:43:34 -07:00
DiffusionRepositoryEditDangerousController.php Provide basic support for Subversion revprops 2016-06-24 13:43:32 -07:00
DiffusionRepositoryEditDeleteController.php Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
DiffusionRepositoryEditUpdateController.php Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
DiffusionRepositoryListController.php Fix two strings with missing pht() 2017-04-07 10:07:01 -07:00
DiffusionRepositoryManageController.php Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
DiffusionRepositoryManagePanelsController.php Modernize Diffusion Create with sidenav, curtain 2017-05-23 11:29:47 -07:00
DiffusionRepositoryProfilePictureController.php Add more repo images 2017-08-08 17:51:15 -07:00
DiffusionRepositoryTestAutomationController.php Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
DiffusionRepositoryURICredentialController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionRepositoryURIDisableController.php Prevent users from disabling repository builtin URIs 2016-05-12 12:09:23 -07:00
DiffusionRepositoryURIEditController.php Flesh out more web UI actions for new URI interface 2016-04-29 17:16:15 -07:00
DiffusionRepositoryURIViewController.php Correct a datasource issue when viewing repository URIs in "Manage Repository" 2017-06-30 07:09:53 -07:00
DiffusionServeController.php Rename "PhabricatorHash::digest()" to "weakDigest()" 2017-04-06 15:43:33 -07:00
DiffusionSymbolController.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
DiffusionTagListController.php Add tabs to Diffusion for consistent navigation 2017-07-05 22:09:36 +01:00